lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Feb 2022 16:14:49 -0500 From: Felix Kuehling <felix.kuehling@....com> To: Yang Li <yang.lee@...ux.alibaba.com>, daniel@...ll.ch Cc: airlied@...ux.ie, alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com> Subject: Re: [PATCH -next] drm/amdkfd: Fix NULL but dereferenced coccicheck error On 2022-02-08 20:39, Yang Li wrote: > Eliminate the following coccicheck warning: > ./drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:2087:27-38: ERROR: bo_buckets > is NULL but dereferenced. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com> Thank you. I already picket up Tom Rix's patch for the same issue. Regards, Felix > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > index 64e3b4e3a712..636391c61caf 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > @@ -1982,10 +1982,8 @@ static int criu_checkpoint_bos(struct kfd_process *p, > void *mem; > > bo_buckets = kvzalloc(num_bos * sizeof(*bo_buckets), GFP_KERNEL); > - if (!bo_buckets) { > - ret = -ENOMEM; > - goto exit; > - } > + if (!bo_buckets) > + return -ENOMEM; > > bo_privs = kvzalloc(num_bos * sizeof(*bo_privs), GFP_KERNEL); > if (!bo_privs) {
Powered by blists - more mailing lists