linux-kernel - Re: [PATCH] fbcon: use min() to make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bfcb259-5f81-2110-2027-cc9e61d4d671@gmx.de>
Date:   Wed, 9 Feb 2022 22:24:47 +0100
From:   Helge Deller <deller@....de>
To:     Sam Ravnborg <sam@...nborg.org>, cgel.zte@...il.com
Cc:     linux-fbdev@...r.kernel.org, ducheng2@...il.com,
        penguin-kernel@...ove.sakura.ne.jp, daniel.vetter@...ll.ch,
        Zeal Robot <zealci@....com.cn>, deng.changcheng@....com.cn,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        cssk@...-c.es, geert@...ux-m68k.org, svens@...ckframe.org
Subject: Re: [PATCH] fbcon: use min() to make code cleaner

On 2/9/22 19:54, Sam Ravnborg wrote:
> On Wed, Feb 09, 2022 at 08:48:10AM +0000, cgel.zte@...il.com wrote:
>> From: Changcheng Deng <deng.changcheng@....com.cn>
>>
>> Use min() in order to make code cleaner.
>>
>> Reported-by: Zeal Robot <zealci@....com.cn>
>> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> Reviewed-by: Sam Ravnborg <sam@...nborg.org>
>
> I had preferred in minmax.h was included, but it has an indirect include
> so shrug.
>
> I assume Daniel or Helge will pick it up.

Daniel has quite some upcoming changes to core/fbcon, so I prefer
that he takes it when he thinks it's the right time...

Helge

>
>> ---
>>  drivers/video/fbdev/core/fbcon.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>> index f36829eeb5a9..61171159fee2 100644
>> --- a/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> @@ -602,7 +602,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,
>>  		save = kmalloc(array3_size(logo_lines, new_cols, 2),
>>  			       GFP_KERNEL);
>>  		if (save) {
>> -			int i = cols < new_cols ? cols : new_cols;
>> +			int i = min(cols, new_cols);
>>  			scr_memsetw(save, erase, array3_size(logo_lines, new_cols, 2));
>>  			r = q - step;
>>  			for (cnt = 0; cnt < logo_lines; cnt++, r += i)
>> --
>> 2.25.1