linux-kernel - Re: [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgM1w1yTd2XkOEAA@google.com>
Date:   Wed, 9 Feb 2022 11:32:19 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Benson Leung <bleung@...omium.org>,
        "open list:CHROMEOS EC USB TYPE-C DRIVER" 
        <chrome-platform@...ts.linux.dev>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state
 inside configure_mux

On Tue, Feb 08, 2022 at 06:47:20PM +0000, Prashant Malani wrote:
> Move the function which gets current mux state inside the
> cros_typec_configure_mux() function. It is better to group those
> bits of functionality together, and it makes it easier to move around
> cros_typec_configure_mux() later.
> 
> While we are doing this, also inline the cros_typec_get_mux_info() inside
> of cros_typec_configure_mux().
> 
> Signed-off-by: Prashant Malani <pmalani@...omium.org>

Reviewed-by: Tzung-Bi Shih <tzungbi@...gle.com>