linux-kernel - Re: [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Feb 2022 13:29:08 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Paul Davey <paul.davey@...iedtelesis.co.nz>
Cc:     Hemant Kumar <hemantk@...eaurora.org>,
        Bhaumik Bhatt <bbhatt@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] bus: mhi: Fix MHI on big endian architectures

On Thu, Aug 12, 2021 at 03:16:58PM +1200, Paul Davey wrote:
> I encountered some problems getting the MHI driver to work on an Octeon
> 3 platform these seem to all be related to endianness issues.  The modem
> interface appears to require the DMA structures to be in little endian,
> however the MHI core driver was assembling them in native endianness.
> 
> Using little endian explicitly allows the interface to function as
> expected.
> 
> Changes in v4:
>   - add Fixes and Reviewed-By tags as requested/offered.
> Changes in v3:
>   - removed change of doorbell helper functions db_val type from
>     dma_addr_t to __le64 favouring doing conversion only when writing to
>     context wp fields.  
> Changes in v2:
>   - use __fls instead of find_last_bit in pm_state conversion patch as
>     requested by Hemant Kumar <hemantk@...eaurora.org>
> 
> Paul Davey (2):
>   bus: mhi: Fix pm_state conversion to string
>   bus: mhi: Fix MHI DMA structure endianness

I've included these two patches two my MHI endpoint patch series. But I
hope to merge these along with MHI host cleanup patches separately for
v5.18.

Thanks,
Mani

> 
>  drivers/bus/mhi/core/debugfs.c  |  26 +++----
>  drivers/bus/mhi/core/init.c     |  43 ++++++------
>  drivers/bus/mhi/core/internal.h | 119 ++++++++++++++++----------------
>  drivers/bus/mhi/core/main.c     |  22 +++---
>  drivers/bus/mhi/core/pm.c       |   4 +-
>  5 files changed, 109 insertions(+), 105 deletions(-)
> 
> -- 
> 2.32.0
>