linux-kernel - Re: [PATCH -next] thermal: intel: INTEL_HFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f8915fd15862a70ed5c4b92632bbe6035b8ea57.camel@linux.intel.com>
Date:   Tue, 08 Feb 2022 17:20:55 -0800
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Aubrey Li <aubrey.li@...ux.intel.com>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] thermal: intel: INTEL_HFI_THERMAL depends on NET

On Tue, 2022-02-08 at 16:15 -0800, Randy Dunlap wrote:
> THERMAL_NETLINK depends on NET and since 'select' does not follow
> any dependency chain, INTEL_HFI_THERMAL also should depend on NET.
> 
> Fix one Kconfig warning and 48 subsequent build errors:
> 
> WARNING: unmet direct dependencies detected for THERMAL_NETLINK
>   Depends on [n]: THERMAL [=y] && NET [=n]
>   Selected by [y]:
>   - INTEL_HFI_THERMAL [=y] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=y]) && CPU_SUP_INTEL [=y] &&
> X86_THERMAL_VECTOR [=y]
> 
Thanks for the fix.

> Fixes: bd30cdfd9bd7 ("thermal: intel: hfi: Notify user space for HFI
> events")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Aubrey Li <aubrey.li@...ux.intel.com>
> Cc: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
> Cc: Rafael J. Wysocki <rafael@...nel.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Amit Kucheria <amitk@...nel.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: linux-pm@...r.kernel.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
> Found in mmotm, linux-next.patch.
> 
>  drivers/thermal/intel/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- mmotm-2022-0208-1531.orig/drivers/thermal/intel/Kconfig
> +++ mmotm-2022-0208-1531/drivers/thermal/intel/Kconfig
> @@ -102,6 +102,7 @@ config INTEL_MENLOW
>  
>  config INTEL_HFI_THERMAL
>         bool "Intel Hardware Feedback Interface"
> +       depends on NET
>         depends on CPU_SUP_INTEL
>         depends on X86_THERMAL_VECTOR
>         select THERMAL_NETLINK