linux-kernel - Re: [PATCH] lima: avoid error task dump attempt when not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <923c1fb9-ec5d-8b6b-96d8-3af6c1c4c8bc@redhat.com>
Date:   Wed, 9 Feb 2022 10:26:48 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Erico Nunes <nunes.erico@...il.com>, Qiang Yu <yuq825@...il.com>,
        dri-devel@...ts.freedesktop.org
Cc:     David Airlie <airlied@...ux.ie>, lima@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lima: avoid error task dump attempt when not enabled

Hello Erico,

On 2/5/22 19:59, Erico Nunes wrote:
> Currently when users try to run an application with lima and that hits
> an issue such as a timeout, a message saying "fail to save task state"
> and "error task list is full" is shown in dmesg.
> 
> The error task dump is a debug feature disabled by default, so the
> error task list is usually not going to be available at all.
> The message can be misleading and creates confusion in bug reports.
> 
> We can avoid that code path and that particular message when the user
> has not explicitly set the max_error_tasks parameter to enable the
> feature.
> 
> Signed-off-by: Erico Nunes <nunes.erico@...il.com>
> ---

Looks good to me. 

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat