linux-kernel - RE: [PATCH v3] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB48651A1E2F29073C711428B1922E9@CO1PR11MB4865.namprd11.prod.outlook.com>
Date:   Wed, 9 Feb 2022 10:23:31 +0000
From:   <Kavyasree.Kotagiri@...rochip.com>
To:     <arnd@...db.de>
CC:     <Nicolas.Ferre@...rochip.com>, <olof@...om.net>, <soc@...nel.org>,
        <robh+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v3] ARM: dts: add DT for lan966x SoC and 2-port board
 pcb8291

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Wed, Feb 9, 2022 at 10:02 AM <Kavyasree.Kotagiri@...rochip.com>
> wrote:
> > > > On 13/01/2022 at 09:00, Kavyasree Kotagiri wrote:
> 
> > > > > +&gpio {
> > > > > +     fc_shrd7_pins: fc_shrd7-pins {
> > > > > +             pins = "GPIO_49";
> > > > > +             function = "fc_shrd7";
> > > > > +     };
> > >
> > > These properties don't look like most pinctrl nodes, has the binding
> > > been reviewed?
> > > I don't see it in Documentation/devicetree/bindings/pinctrl/
> > >
> > This is similar to the ones used in Microchip Ocelot and Sparx5 pinctrl.
> > For example, see usart_pins of gpio nodes in below links:
> > https://sbexr.rabexc.org/latest/sources//84/d39b543790ff25.jhtml
> >
> https://searchcode.com/file/333750634/arch/mips/boot/dts/mscc/ocelot.dt
> si/
> 
> Ok, I see, so this was reviewed by both Rob and LinusW, I assume it's fine
> then, though the use of strings with capital letters, with all pins
> named "GPIO_*"
> still looks odd.
> 
> For my understanding, would you describe the lan966x family as
> a follow-up to Ocelot, with the CPU cores replaced and flexcom added,
> or should I think of it as a SAMA7 based SoC design that incorporates
> the Vitesse switch IP?
> 
No, Only GPIO controller block is similar to the one on Ocelot board and FireAnt platforms. 
Only difference is LAN966 pinctrl supports 8 ALT modes for which it requires three
ALT registers to be configured. Whereas, ocelot and Fireant support 4 ALT modes.

>         Arnd