linux-kernel - Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgOtN+wha+j3ZFIO@smile.fi.intel.com>
Date:   Wed, 9 Feb 2022 14:01:59 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Nuno Sá <noname.nuno@...il.com>
Cc:     Antoniu Miclaus <antoniu.miclaus@...log.com>, jic23@...nel.org,
        robh+dt@...nel.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] iio:frequency:admv1014: add support for ADMV1014

On Mon, Feb 07, 2022 at 09:29:54PM +0100, Nuno Sá wrote:
> On Sat, 2022-02-05 at 20:23 +0200, Andy Shevchenko wrote:
> > On Mon, Jan 31, 2022 at 12:00:59PM +0200, Antoniu Miclaus wrote:
> > > The ADMV1014 is a silicon germanium (SiGe), wideband,
> > > microwave downconverter optimized for point to point microwave
> > > radio designs operating in the 24 GHz to 44 GHz frequency range.
> > 
> > Excellent job!
> > A few comments / questions below.
> > 
> > ...
> > 
> > > +config ADMV1014
> > > +       tristate "Analog Devices ADMV1014 Microwave Downconverter"
> > > +       depends on SPI && COMMON_CLK && 64BIT
> > 
> > Why 64BIT only?
> 
> Could not resist on this one... The thing is that CCF uses unsigned
> long for rates and this part operates in high GHz values. That means,
> as CCF stands, this cannot work on 32bit.

I read it a bit differently, i.e. CCF has a bug that needs to be addressed.

-- 
With Best Regards,
Andy Shevchenko