linux-kernel - Re: [PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Feb 2022 13:37:51 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Noralf Trønnes <noralf@...nnes.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Maxime Ripard <maxime@...no.tech>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH v3 0/7] drm: Add driver for Solomon SSD130X OLED displays

Hello Geert,

On 2/9/22 13:19, Geert Uytterhoeven wrote:
> Hi Javier,
> 
> On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas
> <javierm@...hat.com> wrote:
>> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306,
>> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver.
> 
> [...]
> 
>> - Fix a bug when doing partial updates (Geert Uytterhoeven)
> 
> Thanks, the text console is now more or less working as expected.

Thanks for giving it a try to this version too! Glad to know that
is working better now.

> There is still an issue with the cursor, though.
> After doing "echo hello > /dev/tty0", the text appears, but the cursor
> is gone. "clear > /dev/tty0" brings it back.
>

Hmm, I was able to reproduce this too. Thanks for pointing it out,
I'll investigate what the problem is.
 
> The execution time of "time ls" has improved. It now takes 1.21s
> (0.86s with ssd1306fb).
>

Yes, I believe that was due the bug I mentioned that partial updates
weren't done but a full screen update instead.
 
> The logo is not shown, even when I create a 16-color or 224-color
> version of the small monochrome logo I'm using.
>

I'll also dig into this.

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat