linux-kernel - Re: [PATCH RFC v1] tmpfs: support for file creation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220209152730.13f52fa2@endymion.delvare>
Date:   Wed, 9 Feb 2022 15:27:30 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Xavier Roche <xavier.roche@...olia.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH RFC v1] tmpfs: support for file creation time

On Sat, 5 Feb 2022 15:12:33 +0100, Xavier Roche wrote:
> Various filesystems (including ext4) now support file creation time.
> This patch tentatively adds such support for tmpfs-based filesystems.
> 
> The reason is that creation time has been supported on an increasing number
> of filesystems (this information can be retrieved through the statx()
> userland function), and its support for tmpfs would add consistency.
> Example of use includes checking the creation time of an ephemeral status file
> being updated (such as a "work in progress" placeholder), to get two time
> points (starting point and last update).
> 
> Note that I am nothing but a new contributor, and while this patch has
> been tested (and userland results checked), the logic might be broken.
> 
> Signed-off-by: Xavier Roche <xavier.roche@...olia.com>
> ---
>  include/linux/shmem_fs.h |  1 +
>  mm/shmem.c               | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> (...)

Tested-by: Jean Delvare <jdelvare@...e.de>

Code looks reasonable, but take my review with a grain of salt as this
isn't my area.

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support