linux-kernel - Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgPdYw6hDoN198Hf@smile.fi.intel.com>
Date:   Wed, 9 Feb 2022 17:27:31 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jan Dabros <jsd@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        hdegoede@...hat.com, wsa@...nel.org, rrangel@...omium.org,
        mw@...ihalf.com, jaz@...ihalf.com, upstream@...ihalf.com,
        thomas.lendacky@....com, alexander.deucher@....com,
        Nimesh.Easow@....com, mario.limonciello@....com
Subject: Re: [PATCH v4 2/2] i2c: designware: Add AMD PSP I2C bus support

On Tue, Feb 08, 2022 at 03:12:18PM +0100, Jan Dabros wrote:

...

I have noticed code duplication.

> +	status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
> +	if (status) {
> +		if (status == -ETIMEDOUT)
> +			dev_err(psp_i2c_dev, "Timed out waiting for PSP to release I2C bus\n");
> +		else
> +			dev_err(psp_i2c_dev, "PSP communication error\n");
> +
> +		dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
> +		psp_i2c_mbox_fail = true;
> +		goto cleanup;
> +	}

> +	/* Send a release command to PSP */
> +	status = psp_send_i2c_req(PSP_I2C_REQ_RELEASE);
> +	if (status) {
> +		if (status == -ETIMEDOUT)
> +			dev_err(psp_i2c_dev, "Timed out waiting for PSP to acquire I2C bus\n");
> +		else
> +			dev_err(psp_i2c_dev, "PSP communication error\n");
> +
> +		dev_err(psp_i2c_dev, "Assume i2c bus is for exclusive host usage\n");
> +		psp_i2c_mbox_fail = true;
> +		goto cleanup;
> +	}

If you are going to update the series, consider to introduce a common helper.
Otherwise, consider a follow up.

-- 
With Best Regards,
Andy Shevchenko