linux-kernel - RE: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <MW4PR02MB71863A6E5EBF0884EFA18671E12F9@MW4PR02MB7186.namprd02.prod.outlook.com>
Date:   Thu, 10 Feb 2022 17:23:56 +0000
From:   Sankeerth Billakanti <sbillaka@....qualcomm.com>
To:     "dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
        "Sankeerth Billakanti (QUIC)" <quic_sbillaka@...cinc.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "freedreno@...ts.freedesktop.org" <freedreno@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "agross@...nel.org" <agross@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "robdclark@...il.com" <robdclark@...il.com>,
        "seanpaul@...omium.org" <seanpaul@...omium.org>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "dianders@...omium.org" <dianders@...omium.org>,
        "krzysztof.kozlowski@...onical.com" 
        <krzysztof.kozlowski@...onical.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "sam@...nborg.org" <sam@...nborg.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     quic_kalyant <quic_kalyant@...cinc.com>,
        "Abhinav Kumar (QUIC)" <quic_abhinavk@...cinc.com>,
        "Kuogee Hsieh (QUIC)" <quic_khsieh@...cinc.com>,
        quic_mkrishn <quic_mkrishn@...cinc.com>,
        quic_vproddut <quic_vproddut@...cinc.com>
Subject: RE: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

Hi Dmitry,

As discussed over a separate email, we will be exploring using the generic panel edp and aux bus after implementing the basic PSR feature. We are using a non-generic compatible string now because we enabled PSR with this. The changes from aux-bus and generic-edp may be intrusive for the dp driver and hence we want to explore it as a separate task/feature after the basic PSR feature.

Thank you,
Sankeerth

-----Original Message-----
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
Sent: Thursday, February 10, 2022 5:55 PM
To: Sankeerth Billakanti (QUIC) <quic_sbillaka@...cinc.com>; dri-devel@...ts.freedesktop.org; linux-arm-msm@...r.kernel.org; freedreno@...ts.freedesktop.org; linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; agross@...nel.org; bjorn.andersson@...aro.org; robh+dt@...nel.org; robdclark@...il.com; seanpaul@...omium.org; swboyd@...omium.org; dianders@...omium.org; krzysztof.kozlowski@...onical.com; thierry.reding@...il.com; sam@...nborg.org; airlied@...ux.ie; daniel@...ll.ch
Cc: quic_kalyant <quic_kalyant@...cinc.com>; Abhinav Kumar (QUIC) <quic_abhinavk@...cinc.com>; Kuogee Hsieh (QUIC) <quic_khsieh@...cinc.com>; quic_mkrishn <quic_mkrishn@...cinc.com>; quic_vproddut <quic_vproddut@...cinc.com>
Subject: Re: [PATCH v3 3/4] drm/panel-edp: Add eDP sharp panel support

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

On 09/02/2022 11:55, Sankeerth Billakanti wrote:
> Add support for the 14" sharp,lq140m1jw46 eDP panel.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@...cinc.com>

Please excuse my ignorance, is there any reason, why we can't use generic panel-edp here?

> ---
>
> Changes in v3:
>    None
>
>   drivers/gpu/drm/panel/panel-edp.c | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c 
> b/drivers/gpu/drm/panel/panel-edp.c
> index a394a15..5d13ccc 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1605,6 +1605,34 @@ static const struct panel_desc sharp_lq123p1jx31 = {
>       },
>   };
>
> +static const struct drm_display_mode sharp_lq140m1jw46_mode = {
> +     .clock = 144370,
> +     .hdisplay = 1920,
> +     .hsync_start = 1920 + 48,
> +     .hsync_end = 1920 + 48 + 32,
> +     .htotal = 1920 + 48 + 32 + 80,
> +     .vdisplay = 1080,
> +     .vsync_start = 1080 + 3,
> +     .vsync_end = 1080 + 3 + 5,
> +     .vtotal = 1080 + 3 + 5 + 69,
> +     .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, };
> +
> +static const struct panel_desc sharp_lq140m1jw46 = {
> +     .modes = &sharp_lq140m1jw46_mode,
> +     .num_modes = 1,
> +     .bpc = 8,
> +     .size = {
> +             .width = 309,
> +             .height = 174,
> +     },
> +     .delay = {
> +             .hpd_absent = 80,
> +             .enable = 50,
> +             .unprepare = 500,
> +     },
> +};
> +
>   static const struct drm_display_mode starry_kr122ea0sra_mode = {
>       .clock = 147000,
>       .hdisplay = 1920,
> @@ -1719,6 +1747,9 @@ static const struct of_device_id platform_of_match[] = {
>               .compatible = "sharp,lq123p1jx31",
>               .data = &sharp_lq123p1jx31,
>       }, {
> +             .compatible = "sharp,lq140m1jw46",
> +             .data = &sharp_lq140m1jw46,
> +     }, {
>               .compatible = "starry,kr122ea0sra",
>               .data = &starry_kr122ea0sra,
>       }, {


--
With best wishes
Dmitry