linux-kernel - Re: [PATCH] remoteproc: fix minmax.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220210175847.GA3603040@p14s>
Date:   Thu, 10 Feb 2022 10:58:47 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Wendy Liang <wendy.liang@...inx.com>,
        Michal Simek <monstr@...str.eu>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] remoteproc: fix minmax.cocci warnings

Hi,

On Tue, Feb 08, 2022 at 09:41:39PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@...el.com>
> 
> The code seems more readable with min.
> 
> Generated by: scripts/coccinelle/misc/minmax.cocci
> 
> Fixes: 2b9408d09dc6 ("remoteproc: Add support for peek from remote and acking kick from remote")
> CC: Wendy Liang <wendy.liang@...inx.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
> 
> ---
> 
> tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
> head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
> commit: 2b9408d09dc6367fd2f0820f0c7beab69e9aed56 [550/872] remoteproc: Add support for peek from remote and acking kick from remote
> :::::: branch date: 7 days ago
> :::::: commit date: 7 days ago
> 
>  remoteproc_sysfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/remoteproc/remoteproc_sysfs.c
> +++ b/drivers/remoteproc/remoteproc_sysfs.c
> @@ -241,7 +241,7 @@ static ssize_t kick_store(struct device
>  	size_t cpy_len;
> 
>  	(void)attr;
> -	cpy_len = count <= sizeof(id) ? count : sizeof(id);
> +	cpy_len = min(count, sizeof(id));

Looking at the min() macro the above would become "count < sizeof(id)" rather
than "count <= sizeof(id)".  I don't have more context into this code because I
can't find it in rproc-next nor today's linux-next, but it is something to look
into.  The patch is also missing the minmax.h include for the min() macro.

Thanks,
Mathieu

>  	memcpy((char *)(&id), buf, cpy_len);
> 
>  	if (rproc->ops->kick)