linux-kernel - Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7e2e7db-fd32-d30c-32f4-8850a00f35d9@wanadoo.fr>
Date:   Thu, 10 Feb 2022 19:33:41 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     patchwork-bot+netdevbpf@...nel.org, Qing Wang <wangqing@...o.com>,
        dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: cavium: use div64_u64() instead of
 do_div()

Le 10/02/2022 à 03:01, Jakub Kicinski a écrit :
> On Wed, 9 Feb 2022 21:01:35 +0100 Christophe JAILLET wrote:
>> Le 09/02/2022 à 14:30, patchwork-bot+netdevbpf@...nel.org a écrit :
>>> Here is the summary with links:
>>>     - net: ethernet: cavium: use div64_u64() instead of do_div()
>>>       https://git.kernel.org/netdev/net-next/c/038fcdaf0470
>>>
>>> You are awesome, thank you!
>>
>> Hi,
>>
>> I think that this patch should be reverted because do_div() and
>> div64_u64() don't have the same calling convention.
>>
>> See [1]
>>
>> [1]:
>> https://lore.kernel.org/linux-kernel/20211117112559.jix3hmx7uwqmuryg@pengutronix.de/
> 
> Would you mind sending a revert?
> 

I don't work on net-next, only linux-next.

I can send a revert once it reaches linux-next but I would be better if 
it is fixed before that.

CJ