linux-kernel - Re: [PATCH] Staging: r8188eu: core: Avoid CamelCase: <bEnterPS>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Feb 2022 19:14:04 -0300
From:   Leonardo Araujo <leonardo.aa88@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] Staging: r8188eu: core: Avoid CamelCase: <bEnterPS>

Mr. Greg,

first of all, thank you for your time and review. I am learning a lot
from your responses since I started contributing, after I came across
a YouTube video of one of your presentations on how to contribute to
the Linux kernel. I will study the documentation more in depth and
send a proper patch series as you requested.

Best regards,

Leonardo Araujo

Atenciosamente,

Eng. M.Sc. Leonardo A. de Araujo


On Thu, Feb 10, 2022 at 3:53 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, Feb 09, 2022 at 05:57:40PM -0300, Leonardo Araujo wrote:
> > Fixed a coding style issue.
>
> Please read the kernel documentation for how to write better subject
> lines and changelog texts.  These need a lot of work, you can't just put
> the checkpatch message in the subject and then nothing in the changelog
> body.
>
> >
> > Signed-off-by: Leonardo Araujo <leonardo.aa88@...il.com>
> > ---
> >  drivers/staging/r8188eu/core/rtw_cmd.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> > index e42119e16284..4ec4da6d3078 100644
> > --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> > @@ -880,7 +880,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chplan)
> >
> >  static void traffic_status_watchdog(struct adapter *padapter)
> >  {
> > -     u8      bEnterPS;
> > +     u8      b_enter_ps;
>
> No, think about what you are changing here.  Why keep the "b" at all?
> What does this variable name?  Why was there a "b" to start with?
>
>
> >       u8      bBusyTraffic = false, bTxBusyTraffic = false, bRxBusyTraffic = false;
>
>
> What about all of these other variables, why ignore them and not send a
> patch series to fix them all up?
>
> Remember where the "b" comes from, this is "hungarian notation" and is
> trying to describe the type of the variable, which makes no sense in
> this century.  Please do not keep it around for no reason at all.
>
> thanks,
>
> greg k-h