linux-kernel - Re: [PATCH v2 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE-0n52vS81GYxBCrxb5jf-BOSebU8j2ZzXB17-tspHbNVGKxA@mail.gmail.com>
Date:   Thu, 10 Feb 2022 14:40:47 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jiri Kosina <jikos@...nel.org>, benjamin.tissoires@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        "Sean O'Brien" <seobrien@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
Subject: Re: [PATCH v2 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic

Quoting Stephen Boyd (2022-02-09 14:55:51)
> This is a follow-on to this thread[1] where we discussed the need to
> support the vivaldi keyboard function row keys in the google hammer
> driver. I've extracted the common code into a new vivaldi-keymap.c file
> that can be used by the various keyboard drivers used on ChromeOS
> devices to expose the function_row_physmap sysfs attribute. That's a
> good place to keep the HID parsing logic for the vivaldi and hammer
> keyboards too, so one function goes there for that as well. Finally, we
> add support for the function row physmap attribute to the hammer driver.
>
> Changes from v1 (https://lore.kernel.org/r/20220204202021.895426-1-swboyd@chromium.org):
>  * Yet another new file for HID part to fix compilation problems
>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: "Sean O'Brien" <seobrien@...omium.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
>
> Stephen Boyd (4):
>   Input: atkbd: Convert function_row_physmap to u16 array

I see that this conversion broke stuff. I'll drop this patch and make it
a u32 and resend.

>   Input: Extract ChromeOS vivaldi physmap show function
>   HID: Extract vivaldi hid feature mapping for use in hid-hammer
>   HID: google: Add support for vivaldi to hid-hammer
>