linux-kernel - [PATCH] drivers/phy: remove unneeded ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220210060529.1608027-1-chi.minghao@zte.com.cn>
Date:   Thu, 10 Feb 2022 06:05:29 +0000
From:   cgel.zte@...il.com
To:     kishon@...com
Cc:     vkoul@...nel.org, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH] drivers/phy: remove unneeded ret variable

From: "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>

Return value from regmap_update_bits() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>
---
 drivers/phy/ti/phy-ti-pipe3.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c
index 2cbc91e535d4..060b68c69ab8 100644
--- a/drivers/phy/ti/phy-ti-pipe3.c
+++ b/drivers/phy/ti/phy-ti-pipe3.c
@@ -318,7 +318,6 @@ static void ti_pipe3_disable_clocks(struct ti_pipe3 *phy);
 
 static int ti_pipe3_power_off(struct phy *x)
 {
-	int ret;
 	struct ti_pipe3 *phy = phy_get_drvdata(x);
 
 	if (!phy->phy_power_syscon) {
@@ -326,9 +325,8 @@ static int ti_pipe3_power_off(struct phy *x)
 		return 0;
 	}
 
-	ret = regmap_update_bits(phy->phy_power_syscon, phy->power_reg,
+	return regmap_update_bits(phy->phy_power_syscon, phy->power_reg,
 				 PIPE3_PHY_PWRCTL_CLK_CMD_MASK, 0);
-	return ret;
 }
 
 static void ti_pipe3_calibrate(struct ti_pipe3 *phy);
-- 
2.25.1