linux-kernel - Re: [PATCH] dt-bindings: pinctrl: mt8195: fix bias-pull-{up,down} checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YgRc860w5Pj6RSlS@robh.at.kernel.org>
Date:   Wed, 9 Feb 2022 18:31:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Chen-Yu Tsai <wenst@...omium.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guodong Liu <guodong.liu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        linux-mediatek@...ts.infradead.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Tinghan Shen <tinghan.shen@...iatek.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: mt8195: fix bias-pull-{up,down}
 checks

On Wed, 02 Feb 2022 23:35:28 +0800, Chen-Yu Tsai wrote:
> When the constraints and description for bias-pull-{up,down} were added,
> the constraints were not indented correctly, resulting in them being
> parsed as part of the description. This effectively nullified their
> purpose.
> 
> Move the constraints out of the description block, make each description
> part of the same associative array as the enum its describing, and
> reindent them correctly so they take effect.
> 
> Also add "type: boolean" to the list of valid values. This corresponds
> to having bias-pull-{up,down} without any arguments.
> 
> Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description")
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> ---
>  .../bindings/pinctrl/pinctrl-mt8195.yaml      | 30 ++++++++++---------
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>