linux-kernel - Re: [PATCH v1 02/14] mtd: spi-nor: slightly refactor the spi_nor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568550c8-c212-573c-5832-3d653c707fff@microchip.com>
Date:   Thu, 10 Feb 2022 08:05:30 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <michael@...le.cc>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <p.yadav@...com>, <miquel.raynal@...tlin.com>, <richard@....at>,
        <vigneshr@...com>
Subject: Re: [PATCH v1 02/14] mtd: spi-nor: slightly refactor the
 spi_nor_setup()

On 2/10/22 10:01, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Am 2022-02-10 04:00, schrieb Tudor.Ambarus@...rochip.com:
>> On 2/2/22 16:58, Michael Walle wrote:

cut

>>> Also mark the parameter as optional now.

Oh, I misread, in my head I read "for now". That's why I asked what should
be done next :).
>>
>> what should be done in the future?
> 
> What do you mean? IMHO the default path should be visible in the
> function. Eg.
> 
> int spi_nor_bla(nor) {
>     if (nor->some_exceptional_cb)
>         return nor->some_exceptional_cb(nor);
> 
>    return usual_cb(nor);
> }
> 
> -michael