lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 10 Feb 2022 09:40:55 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     "yunfei.dong@...iatek.com" <yunfei.dong@...iatek.com>,
        Rob Herring <robh@...nel.org>
Cc:     Alexandre Courbot <acourbot@...omium.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Tzung-Bi Shih <tzungbi@...omium.org>,
        Tiffany Lin <tiffany.lin@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Tomasz Figa <tfiga@...gle.com>,
        George Sun <george.sun@...iatek.com>,
        Xiaoyong Lu <xiaoyong.lu@...iatek.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Fritz Koenig <frkoenig@...omium.org>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Irui Wang <irui.wang@...iatek.com>,
        Steve Cho <stevecho@...omium.org>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, srv_heupstream@...iatek.com,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v2, 1/7] dt-bindings: media: mtk-vcodec: Adds decoder
 dt-bindings for lat soc

Il 10/02/22 04:06, yunfei.dong@...iatek.com ha scritto:
> Hi Rob,
> 
> Thanks for your suggestion.
> On Wed, 2022-02-09 at 14:37 -0600, Rob Herring wrote:
>> On Fri, Jan 28, 2022 at 11:54:34AM +0800, Yunfei Dong wrote:
>>> Adds decoder dt-bindings for compatible "mediatek,mtk-vcodec-lat-
>>> soc".
>>
>> What's lat soc? How does this relate to what's already there in this
>> binding.
>>
> lat soc is another hardware, is related with some vdec larb ports.
> Won't be used to decode, but must to write it in dtsi, or hardware
> can't work well.

Hello Yunfei,

as a suggestion, writing the meaning of the "LAT" acronym may also
help to clear some doubts around (please, also do that in the yaml file,
other than the commit description).

Thank you!
Angelo

> 
> Need to enable clock/power/iommus, no interrupt.
>> The subject space is limited, avoid saying the same thing twice
>> (dt-bindings).
>>
> 
> Best Regards,
> Yunfei Dong
>>>
>>> Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
>>> ---
>>>   .../media/mediatek,vcodec-subdev-decoder.yaml | 49
>>> +++++++++++++++++++
>>>   1 file changed, 49 insertions(+)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
>>> decoder.yaml
>>> b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
>>> decoder.yaml
>>> index 6415c9f29130..a3c892338ac0 100644
>>> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
>>> subdev-decoder.yaml
>>> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
>>> subdev-decoder.yaml
>>> @@ -189,6 +189,55 @@ patternProperties:
>>>   
>>>       additionalProperties: false
>>>   
>>> +  '^vcodec-lat-soc@[0-9a-f]+$':
>>> +    type: object
>>> +
>>> +    properties:
>>> +      compatible:
>>> +        const: mediatek,mtk-vcodec-lat-soc
>>> +
>>> +      reg:
>>> +        maxItems: 1
>>> +
>>> +      iommus:
>>> +        minItems: 1
>>> +        maxItems: 32
>>> +        description: |
>>> +          List of the hardware port in respective IOMMU block for
>>> current Socs.
>>> +          Refer to bindings/iommu/mediatek,iommu.yaml.
>>> +
>>> +      clocks:
>>> +        maxItems: 5
>>> +
>>> +      clock-names:
>>> +        items:
>>> +          - const: sel
>>> +          - const: soc-vdec
>>> +          - const: soc-lat
>>> +          - const: vdec
>>> +          - const: top
>>> +
>>> +      assigned-clocks:
>>> +        maxItems: 1
>>> +
>>> +      assigned-clock-parents:
>>> +        maxItems: 1
>>> +
>>> +      power-domains:
>>> +        maxItems: 1
>>> +
>>> +    required:
>>> +      - compatible
>>> +      - reg
>>> +      - iommus
>>> +      - clocks
>>> +      - clock-names
>>> +      - assigned-clocks
>>> +      - assigned-clock-parents
>>> +      - power-domains
>>> +
>>> +    additionalProperties: false
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>> -- 
>>> 2.25.1
>>>
>>>
> 

Powered by blists - more mailing lists