linux-kernel - Re: [PATCH v1] fbtft: fb_st7789v: added reset on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220210084940.GE10212@optiplex>
Date:   Thu, 10 Feb 2022 09:49:40 +0100
From:   Oliver Graute <oliver.graute@...oconnector.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Carlis <zhangxuezhi1@...ong.com>, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] fbtft: fb_st7789v: added reset on init_display()

On 13/08/21, Greg KH wrote:
> On Fri, Aug 13, 2021 at 02:54:30PM +0200, Oliver Graute wrote:
> > On 13/08/21, Greg KH wrote:
> > > On Fri, Aug 13, 2021 at 08:25:10AM +0200, Oliver Graute wrote:
> > > > staging: fbtft: fb_st7789v: reset display before initialization
> > > 
> > > What is this line here, and why is this not your subject line instead?
> > 
> > I'll put the line as subject instead.
> > 
> > > > In rare cases the display is flipped or mirrored. This was observed more
> > > > often in a low temperature environment. A clean reset on init_display()
> > > > should help to get registers in a sane state.
> > > > 
> > > > Signed-off-by: Oliver Graute <oliver.graute@...oconnector.com>
> > > 
> > > What commit does this fix?
> > 
> > this is a fix for a rare behavior of the fb_st7789v display. Not a
> > bugfix for a specific commit.
> 
> So if it has always been broken, list the commit where the code was
> added to the kernel, as this should be backported to the stable kernels,
> right?

ok thx, will list the commit and add stable@...r.kernel.org to cc

thx,

Oliver