linux-kernel - Re: [PATCH] clk: ingenic-tcu: Fix missing TCU clock for X1000 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edc5bd05-45c3-2284-8655-6c1f3ef20f3b@wanyeetech.com>
Date:   Thu, 10 Feb 2022 17:06:04 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        paul@...pouillou.net, robh+dt@...nel.org, mturquette@...libre.com,
        sboyd@...nel.org
Cc:     linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: ingenic-tcu: Fix missing TCU clock for X1000 SoC

Hi Aidan,

On 2022/2/10 上午7:01, Aidan MacDonald wrote:
> The X1000 does have a TCU clock gate, so pass it to the driver.
> Without this the TCU can be gated automatically, which prevents
> timers from running and stops register writes from taking effect.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
>   arch/mips/boot/dts/ingenic/x1000.dtsi | 5 +++--
>   drivers/clk/ingenic/tcu.c             | 2 +-
>   2 files changed, 4 insertions(+), 3 deletions(-)


Thank you for fixing the problem that I didn't realize at first.

Reviewed-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>


>
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 8bd27edef216..c69df8eb158e 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -111,8 +111,9 @@ tcu: timer@...02000 {
>   
>   		clocks = <&cgu X1000_CLK_RTCLK>,
>   			 <&cgu X1000_CLK_EXCLK>,
> -			 <&cgu X1000_CLK_PCLK>;
> -		clock-names = "rtc", "ext", "pclk";
> +			 <&cgu X1000_CLK_PCLK>,
> +			 <&cgu X1000_CLK_TCU>;
> +		clock-names = "rtc", "ext", "pclk", "tcu";
>   
>   		interrupt-controller;
>   		#interrupt-cells = <1>;
> diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c
> index 77acfbeb4830..9c86043f673a 100644
> --- a/drivers/clk/ingenic/tcu.c
> +++ b/drivers/clk/ingenic/tcu.c
> @@ -320,7 +320,7 @@ static const struct ingenic_soc_info jz4770_soc_info = {
>   static const struct ingenic_soc_info x1000_soc_info = {
>   	.num_channels = 8,
>   	.has_ost = false, /* X1000 has OST, but it not belong TCU */
> -	.has_tcu_clk = false,
> +	.has_tcu_clk = true,
>   };
>   
>   static const struct of_device_id __maybe_unused ingenic_tcu_of_match[] __initconst = {