lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Feb 2022 18:32:27 +0800 From: davidcomponentone@...il.com To: jejb@...ux.ibm.com Cc: davidcomponentone@...il.com, martin.petersen@...cle.com, bvanassche@....org, jiapeng.chong@...ux.alibaba.com, yang.guang5@....com.cn, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn> Subject: [PATCH v2] scsi: csiostor: replace snprintf with sysfs_emit From: Yang Guang <yang.guang5@....com.cn> coccinelle report: ./drivers/scsi/csiostor/csio_scsi.c:1433:8-16: WARNING: use scnprintf or sprintf ./drivers/scsi/csiostor/csio_scsi.c:1369:9-17: WARNING: use scnprintf or sprintf ./drivers/scsi/csiostor/csio_scsi.c:1479:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot <zealci@....com.cn> Signed-off-by: Yang Guang <yang.guang5@....com.cn> Signed-off-by: David Yang <davidcomponentone@...il.com> --- Change from v1-v2: - Adjust some format --- drivers/scsi/csiostor/csio_scsi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c index 55db02521221..05f52fc3efb8 100644 --- a/drivers/scsi/csiostor/csio_scsi.c +++ b/drivers/scsi/csiostor/csio_scsi.c @@ -1365,10 +1365,7 @@ csio_show_hw_state(struct device *dev, struct csio_lnode *ln = shost_priv(class_to_shost(dev)); struct csio_hw *hw = csio_lnode_to_hw(ln); - if (csio_is_hw_ready(hw)) - return snprintf(buf, PAGE_SIZE, "ready\n"); - else - return snprintf(buf, PAGE_SIZE, "not ready\n"); + return sysfs_emit(buf, "%sready\n", csio_is_hw_ready(hw) ? "" : "not "); } /* Device reset */ @@ -1430,7 +1427,7 @@ csio_show_dbg_level(struct device *dev, { struct csio_lnode *ln = shost_priv(class_to_shost(dev)); - return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level); + return sysfs_emit(buf, "%x\n", ln->params.log_level); } /* Store debug level */ @@ -1476,7 +1473,7 @@ csio_show_num_reg_rnodes(struct device *dev, { struct csio_lnode *ln = shost_priv(class_to_shost(dev)); - return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes); + return sysfs_emit(buf, "%u\n", ln->num_reg_rnodes); } static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL); -- 2.30.2
Powered by blists - more mailing lists