linux-kernel - Re: [PATCH v5 6/7] thermal: netlink: Add a new event to notify CPU capabilities change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ede29257-d356-9fc6-5f1a-c42721c0d072@arm.com>
Date:   Thu, 10 Feb 2022 11:22:02 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Len Brown <len.brown@...el.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Aubrey Li <aubrey.li@...ux.intel.com>,
        Amit Kucheria <amitk@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Ricardo Neri <ricardo.neri@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH v5 6/7] thermal: netlink: Add a new event to notify CPU
 capabilities change



On 1/30/22 3:20 PM, Rafael J. Wysocki wrote:
> On Thu, Jan 27, 2022 at 8:33 PM Ricardo Neri
> <ricardo.neri-calderon@...ux.intel.com> wrote:
>>
>> From: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
>>
>> Add a new netlink event to notify change in CPU capabilities in terms of
>> performance and efficiency.
>>
>> Firmware may change CPU capabilities as a result of thermal events in the
>> system or to account for changes in the TDP (thermal design power) level.
>>
>> This notification type will allow user space to avoid running workloads
>> on certain CPUs or proactively adjust power limits to avoid future events.
>>
>> The netlink message consists of a nested attribute
>> (THERMAL_GENL_ATTR_CPU_CAPABILITY) with three attributes:
>>
>>   * THERMAL_GENL_ATTR_CPU_CAPABILITY_ID (type u32):
>>     -- logical CPU number
>>   * THERMAL_GENL_ATTR_CPU_CAPABILITY_PERFORMANCE (type u32):
>>     -- Scaled performance from 0-1023
>>   * THERMAL_GENL_ATTR_CPU_CAPABILITY_EFFICIENCY (type u32):
>>     -- Scaled efficiency from 0-1023
>>
>> Cc: Andi Kleen <ak@...ux.intel.com>
>> Cc: Aubrey Li <aubrey.li@...ux.intel.com>
>> Cc: Lukasz Luba <lukasz.luba@....com>
>> Cc: Tim Chen <tim.c.chen@...ux.intel.com>
>> Cc: "Ravi V. Shankar" <ravi.v.shankar@...el.com>
>> Reviewed-by: Len Brown <len.brown@...el.com>
>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> 
> Daniel, Lukasz, if you have any comments or concerns regarding this
> patch, please let me know.
> 

My apologies Rafael, I missed that email.

I've looked at the patches 6/7 and 7/7 and they look OK with the
scaling.