lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Feb 2022 11:43:48 +0000 From: "Rui Miguel Silva" <rmfrfs@...il.com> To: <cgel.zte@...il.com> Cc: <johan@...nel.org>, <elder@...nel.org>, <gregkh@...uxfoundation.org>, <greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, "Minghao Chi" <chi.minghao@....com.cn>, "Zeal Robot" <zealci@....com.cn> Subject: Re: [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls Hey Minghao, Many thanks for the patch. On Thu Feb 10, 2022 at 6:02 AM WET, wrote: > From: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn> > > 'destroy_workqueue()' already drains the queue before destroying it, > so there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > Reported-by: Zeal Robot <zealci@....com.cn> > Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn> LGTM. Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com> Cheers, Rui > --- > drivers/staging/greybus/sdio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c > index 37bf04c22dbc..25bee5335c70 100644 > --- a/drivers/staging/greybus/sdio.c > +++ b/drivers/staging/greybus/sdio.c > @@ -858,7 +858,6 @@ static void gb_sdio_remove(struct gbphy_device *gbphy_dev) > gb_connection_set_data(connection, NULL); > mutex_unlock(&host->lock); > > - flush_workqueue(host->mrq_workqueue); > destroy_workqueue(host->mrq_workqueue); > gb_connection_disable_rx(connection); > mmc_remove_host(mmc); > -- > 2.25.1
Powered by blists - more mailing lists