linux-kernel - Re: [PATCH] net: fix wrong network header length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Feb 2022 19:56:34 +0800
From:   Lina Wang <lina.wang@...iatek.com>
To:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bpf@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, <maze@...gle.com>,
        <willemb@...gle.com>, <edumazet@...gle.com>,
        <zhuoliang.zhang@...iatek.com>, <chao.song@...iatek.com>,
        "lina . wang" <lina.wang@...iatek.com>
Subject: Re: [PATCH] net: fix wrong network header length

From: lina.wang <lina.wang@...iatek.com>

On Wed, 2022-02-09 at 17:06 -0800, Jakub Kicinski wrote:
> On Wed, 9 Feb 2022 18:25:07 +0800 lina.wang wrote:
> > We use NETIF_F_GRO_FRAGLIST not for forwarding scenary, just for
> > software udp gro. Whatever NETIF_F_GRO_FRAGLIST or NETIF_F_GRO_FWD,
> > skb_segment_list should not have bugs.
> > 
> > We modify skb_segment_list, not in epbf. One point is traversing
> > the
> > segments costly, another is what @Maciej said, *other* helper may
> > have
> > the same problem. In skb_segment_list, it calls
> > skb_headers_offset_update to update different headroom, which
> > implys
> > header maybe different.
> 
> Process notes:
>  - the patch didn't apply so even if the discussion concludes that 
>    the patch was good you'll need to rebase on netdev/net and repost;
>  - please don't top post.

I have rebased and reposted--
https://patchwork.kernel.org/project/netdevbpf/patch/20220210091655.17231-1-lina.wang@mediatek.com/, 
please check if it can apply.

Thanks!