linux-kernel - Re: Query related to shutting down NVMe during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65a50f83e87d4cf8b1ac1b740b4fa35b@codeaurora.org>
Date:   Thu, 10 Feb 2022 18:06:59 +0530
From:   nitirawa@...eaurora.org
To:     Lukas Wunner <lukas@...ner.de>, Keith Busch <kbusch@...nel.org>
Cc:     Vidya Sagar <vidyas@...dia.com>, Keith Busch <kbusch@...nel.org>,
        robh+dt@...nel.org, rafael.j.wysocki@...el.com, hch@....de,
        bhelgaas@...gle.com, mmaddireddy@...dia.com, kthota@...dia.com,
        sagar.tv@...il.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Query related to shutting down NVMe during system suspend

On 2022-02-10 11:10, Lukas Wunner wrote:
> On Thu, Feb 10, 2022 at 09:41:04AM +0530, Vidya Sagar wrote:
>> On 2/10/2022 1:56 AM, Keith Busch wrote:
>> > Christoph prefers to append quirks for platforms that need full device
>> > shutdown on s2idle instead of changing the driver default.
>> >
>> > We use dmi matching for our current platform quirk list. I do not know
>> > what the equivalent is for device-tree based platforms. Do you know?
>> 
>> I'm afraid I don't.
> 
> of_machine_is_compatible()

Thanks Lukas and keith . Yes it worked using of_machine_is_compatible as 
it checks root node of device tree for a given compatible value.
@keith - I have posted the change using above API to enable nvme quick 
suspend quirks for sc7280 platform. Please can you review it.