linux-kernel - Re: [PATCH v2 10/19] fbcon: Ditch error handling for con2fb_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9ab9aee-2a21-0ff6-032a-694066b2588a@suse.de>
Date:   Thu, 10 Feb 2022 15:14:25 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Daniel Vetter <daniel.vetter@...ll.ch>,
        DRI Development <dri-devel@...ts.freedesktop.org>
Cc:     Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        linux-fbdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Claudio Suarez <cssk@...-c.es>, Du Cheng <ducheng2@...il.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Subject: Re: [PATCH v2 10/19] fbcon: Ditch error handling for
 con2fb_release_oldinfo



Am 08.02.22 um 22:08 schrieb Daniel Vetter:
> It doesn't ever fail anymore.
> 
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Claudio Suarez <cssk@...-c.es>
> Cc: Du Cheng <ducheng2@...il.com>
> Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/video/fbdev/core/fbcon.c | 37 +++++++++++---------------------
>   1 file changed, 13 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 3e1a3e7bf527..a60891005d44 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -739,9 +739,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info,
>   	return err;
>   }
>   
> -static int con2fb_release_oldinfo(struct vc_data *vc, struct fb_info *oldinfo,
> -				  struct fb_info *newinfo, int unit,
> -				  int oldidx, int found)
> +static void con2fb_release_oldinfo(struct vc_data *vc, struct fb_info *oldinfo,
> +				   struct fb_info *newinfo)
>   {
>   	struct fbcon_ops *ops = oldinfo->fbcon_par;
>   	int ret;
> @@ -770,8 +769,6 @@ static int con2fb_release_oldinfo(struct vc_data *vc, struct fb_info *oldinfo,
>   				"detected unhandled fb_set_par error, "
>   				"error code %d\n", ret);
>   	}
> -
> -	return 0;
>   }
>   
>   static void con2fb_init_display(struct vc_data *vc, struct fb_info *info,
> @@ -825,7 +822,7 @@ static int set_con2fb_map(int unit, int newidx, int user)
>   	int oldidx = con2fb_map[unit];
>   	struct fb_info *info = registered_fb[newidx];
>   	struct fb_info *oldinfo = NULL;
> -	int found, err = 0;
> +	int found, err = 0, show_logo;
>   
>   	WARN_CONSOLE_UNLOCKED();
>   
> @@ -854,18 +851,15 @@ static int set_con2fb_map(int unit, int newidx, int user)
>   	 * fbcon should release it.
>   	 */
>   	if (!err && oldinfo && !search_fb_in_map(oldidx))
> -		err = con2fb_release_oldinfo(vc, oldinfo, info, unit, oldidx,
> -					     found);
> +		con2fb_release_oldinfo(vc, oldinfo, info);
>   
> -	if (!err) {
> -		int show_logo = (fg_console == 0 && !user &&
> -				 logo_shown != FBCON_LOGO_DONTSHOW);
> +	show_logo = (fg_console == 0 && !user &&
> +			 logo_shown != FBCON_LOGO_DONTSHOW);
>   
> -		if (!found)
> -			fbcon_add_cursor_work(info);
> -		con2fb_map_boot[unit] = newidx;
> -		con2fb_init_display(vc, info, unit, show_logo);
> -	}
> +	if (!found)
> +		fbcon_add_cursor_work(info);
> +	con2fb_map_boot[unit] = newidx;
> +	con2fb_init_display(vc, info, unit, show_logo);
>   
>   	if (!search_fb_in_map(info_idx))
>   		info_idx = newidx;
> @@ -2769,7 +2763,7 @@ static inline void fbcon_unbind(void) {}
>   /* called with console_lock held */
>   void fbcon_fb_unbind(struct fb_info *info)
>   {
> -	int i, new_idx = -1, ret = 0;
> +	int i, new_idx = -1;
>   	int idx = info->node;
>   
>   	WARN_CONSOLE_UNLOCKED();
> @@ -2803,13 +2797,8 @@ void fbcon_fb_unbind(struct fb_info *info)
>   			if (con2fb_map[i] == idx) {
>   				con2fb_map[i] = -1;
>   				if (!search_fb_in_map(idx)) {
> -					ret = con2fb_release_oldinfo(vc_cons[i].d,
> -								     info, NULL, i,
> -								     idx, 0);
> -					if (ret) {
> -						con2fb_map[i] = idx;
> -						return;
> -					}
> +					con2fb_release_oldinfo(vc_cons[i].d,
> +							       info, NULL);
>   				}
>   			}
>   		}

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)