linux-kernel - Re: [PATCH 9/9] ASoC: SOF: Convert the generic probe support to SOF client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d1ed0e0-e69e-e725-b820-4a1c04ecdf4c@linux.intel.com>
Date:   Thu, 10 Feb 2022 16:50:50 +0200
From:   Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org,
        kai.vehmanen@...ux.intel.com, linux-kernel@...r.kernel.org,
        tiwai@...e.com, ranjani.sridharan@...ux.intel.com,
        lgirdwood@...il.com, fred.oh@...ux.intel.com, daniel.baluta@....com
Subject: Re: [PATCH 9/9] ASoC: SOF: Convert the generic probe support to SOF
 client



On 10/02/2022 16:41, Péter Ujfalusi wrote:
> 
> 
> On 10/02/2022 15:54, Mark Brown wrote:
>> On Thu, Feb 10, 2022 at 12:55:19PM +0200, Peter Ujfalusi wrote:
>>> Add a new client driver for probes support and move
>>> all the probes-related code from the core to the
>>> client driver.
>>
>> This breaks an x86 allmodconfig build:
>>
>> /mnt/kernel/sound/soc/sof/compress.c: In function 'create_page_table':
>> /mnt/kernel/sound/soc/sof/compress.c:87:9: error: implicit declaration of function 'snd_sof_create_page_table'; did you mean 'create_page_table'? [-Werror=implicit-function-declaration]
>>    87 |  return snd_sof_create_page_table(component->dev, dmab,
>>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~
>>       |         create_page_table
> 
> Interesting, we have this under constant builds for months and we
> certainly are building things as modules.
> 
> Let me check and fix this.

This patch never got reviewed in SOF:
ASoC: SOF: compr: Add compress ops implementation

and this introduced the use of snd_sof_create_page_table()

I don't sof-compress enabled, only imx and mediatek have it enabled.

Daniel, were there any reason to not send this to sof-dev prior?

-- 
Péter