| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <838394d2-bc47-1a8b-56dd-320d0df39dfe@canonical.com>
Date: Thu, 10 Feb 2022 17:12:29 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Corentin Labbe <clabbe@...libre.com>,
damien.lemoal@...nsource.wdc.com, robh+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v4] dt-bindings: convert ata/cortina,gemini-sata-bridge to
yaml
On 10/02/2022 17:07, Corentin Labbe wrote:
> This patch converts ata/cortina,gemini-sata-bridge binding to yaml
>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Acked-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
> Change since v1:
> - fixed cosmetic nits reported by Damien Le Moal
> Changes since v2:
> - Added blank lines between properties
> - Removed useless quotes and label
> - Re-indented description
> Change since v3:
> - fixed all min/maxitems reported by Krzysztof Kozlowski
>
> .../ata/cortina,gemini-sata-bridge.txt | 55 ---------
> .../ata/cortina,gemini-sata-bridge.yaml | 109 ++++++++++++++++++
> 2 files changed, 109 insertions(+), 55 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
> create mode 100644 Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
> deleted file mode 100644
> index 1c3d3cc70051..000000000000
> --- a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.txt
> +++ /dev/null
> @@ -1,55 +0,0 @@
> -* Cortina Systems Gemini SATA Bridge
> -
> -The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
> -takes two Faraday Technology FTIDE010 PATA controllers and bridges
> -them in different configurations to two SATA ports.
> -
> -Required properties:
> -- compatible: should be
> - "cortina,gemini-sata-bridge"
> -- reg: registers and size for the block
> -- resets: phandles to the reset lines for both SATA bridges
> -- reset-names: must be "sata0", "sata1"
> -- clocks: phandles to the compulsory peripheral clocks
> -- clock-names: must be "SATA0_PCLK", "SATA1_PCLK"
> -- syscon: a phandle to the global Gemini system controller
> -- cortina,gemini-ata-muxmode: tell the desired multiplexing mode for
> - the ATA controller and SATA bridges. Values 0..3:
> - Mode 0: ata0 master <-> sata0
> - ata1 master <-> sata1
> - ata0 slave interface brought out on IDE pads
> - Mode 1: ata0 master <-> sata0
> - ata1 master <-> sata1
> - ata1 slave interface brought out on IDE pads
> - Mode 2: ata1 master <-> sata1
> - ata1 slave <-> sata0
> - ata0 master and slave interfaces brought out
> - on IDE pads
> - Mode 3: ata0 master <-> sata0
> - ata0 slave <-> sata1
> - ata1 master and slave interfaces brought out
> - on IDE pads
> -
> -Optional boolean properties:
> -- cortina,gemini-enable-ide-pins: enables the PATA to IDE connection.
> - The muxmode setting decides whether ATA0 or ATA1 is brought out,
> - and whether master, slave or both interfaces get brought out.
> -- cortina,gemini-enable-sata-bridge: enables the PATA to SATA bridge
> - inside the Gemnini SoC. The Muxmode decides what PATA blocks will
> - be muxed out and how.
> -
> -Example:
> -
> -sata: sata@...00000 {
> - compatible = "cortina,gemini-sata-bridge";
> - reg = <0x46000000 0x100>;
> - resets = <&rcon 26>, <&rcon 27>;
> - reset-names = "sata0", "sata1";
> - clocks = <&gcc GEMINI_CLK_GATE_SATA0>,
> - <&gcc GEMINI_CLK_GATE_SATA1>;
> - clock-names = "SATA0_PCLK", "SATA1_PCLK";
> - syscon = <&syscon>;
> - cortina,gemini-ata-muxmode = <3>;
> - cortina,gemini-enable-ide-pins;
> - cortina,gemini-enable-sata-bridge;
> -};
> diff --git a/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
> new file mode 100644
> index 000000000000..77af2559b097
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/cortina,gemini-sata-bridge.yaml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/cortina,gemini-sata-bridge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cortina Systems Gemini SATA Bridge
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@...aro.org>
> +
> +description: |
> + The Gemini SATA bridge in a SoC-internal PATA to SATA bridge that
> + takes two Faraday Technology FTIDE010 PATA controllers and bridges
> + them in different configurations to two SATA ports.
> +
> +properties:
> + compatible:
> + const: cortina,gemini-sata-bridge
> +
> + reg:
> + maxItems: 1
> +
> + resets:
> + minItems: 2
> + maxItems: 2
> + description: phandles to the reset lines for both SATA bridges
> +
> + reset-names:
> + items:
> + - const: sata0
> + - const: sata1
> +
> + clocks:
> + minItems: 2
> + maxItems: 2
> + description: phandles to the compulsory peripheral clocks
> +
> + clock-names:
> + items:
> + - const: SATA0_PCLK
> + - const: SATA1_PCLK
> +
> + syscon:
> + maxItems: 1
My bad, I am sorry for misleading you earlier, this is just a phandle,
so should be without any min/maxItems.
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: a phandle to the global Gemini system controller
> +
With maxItems removed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Best regards,
Krzysztof
Powered by blists - more mailing lists