linux-kernel - Re: [PATCH] exec: cleanup comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Feb 2022 09:12:13 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     trix@...hat.com, ebiederm@...ssion.com, keescook@...omium.org,
        viro@...iv.linux.org.uk
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] exec: cleanup comments



On 2/11/22 08:09, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Remove the second 'from'.
> Replace 'backwords' with 'backwards'.
> Replace 'visibile' with 'visible'.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  fs/exec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 40b1008fb0f7..8256e8bb9ad3 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -118,7 +118,7 @@ bool path_noexec(const struct path *path)
>   * Note that a shared library must be both readable and executable due to
>   * security reasons.
>   *
> - * Also note that we take the address to load from from the file itself.
> + * Also note that we take the address to load from the file itself.
>   */
>  SYSCALL_DEFINE1(uselib, const char __user *, library)
>  {
> @@ -542,7 +542,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>  		if (!valid_arg_len(bprm, len))
>  			goto out;
>  
> -		/* We're going to work our way backwords. */
> +		/* We're going to work our way backwards. */
>  		pos = bprm->p;
>  		str += len;
>  		bprm->p -= len;
> @@ -1275,7 +1275,7 @@ int begin_new_exec(struct linux_binprm * bprm)
>  
>  	/*
>  	 * Must be called _before_ exec_mmap() as bprm->mm is
> -	 * not visibile until then. This also enables the update
> +	 * not visible until then. This also enables the update
>  	 * to be lockless.
>  	 */
>  	retval = set_mm_exe_file(bprm->mm, bprm->file);

-- 
~Randy