linux-kernel - Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f8e8e3d-8bd7-dfd4-f4a0-63520d817c10@redhat.com>
Date:   Fri, 11 Feb 2022 18:28:34 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        mlevitsk@...hat.com
Subject: Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and
 AVIC inhibition

On 2/11/22 18:11, Sean Christopherson wrote:
>> +		/* Process the interrupt with a vmexit.  */
>
> Double spaces at the end.  But I would prefer we omit the comment entirely,
> there is no guarantee the vCPU is in the guest or even running.

Sure, or perhaps "process the interrupt in inject_pending_event".

Regarding the two spaces, it used to a pretty strict rule in the US with 
typewriters.  It helps readability of monospaced fonts 
(https://www.cultofpedagogy.com/two-spaces-after-period/), and code is 
mostly monospaced...  But well, the title of the article says it all.

Paolo