linux-kernel - Re: [PATCH v1 1/1] ACPI: Switch to use list_entry_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202202120054.idhiETlD-lkp@intel.com>
Date:   Sat, 12 Feb 2022 01:59:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Hui Wang <hui.wang@...onical.com>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev
Cc:     kbuild-all@...ts.01.org, Len Brown <lenb@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH v1 1/1] ACPI: Switch to use list_entry_is_head() helper

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on nvdimm/libnvdimm-for-next v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-Switch-to-use-list_entry_is_head-helper/20220211-190438
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220212/202202120054.idhiETlD-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/95f7c8c71bb18e505f5399a87cbb192f481c86fe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/ACPI-Switch-to-use-list_entry_is_head-helper/20220211-190438
        git checkout 95f7c8c71bb18e505f5399a87cbb192f481c86fe
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/acpi/acpi_ipmi.c: In function 'ipmi_cancel_tx_msg':
>> drivers/acpi/acpi_ipmi.c:369:17: error: expected ')' before 'return'
     369 |                 return;
         |                 ^~~~~~
   drivers/acpi/acpi_ipmi.c:368:12: note: to match this '('
     368 |         if (list_entry_is_head(tx_msg, &ipmi->tx_msg_list, head)
         |            ^
>> drivers/acpi/acpi_ipmi.c:372:1: error: expected expression before '}' token
     372 | }
         | ^


vim +369 drivers/acpi/acpi_ipmi.c

   352	
   353	static void ipmi_cancel_tx_msg(struct acpi_ipmi_device *ipmi,
   354				       struct acpi_ipmi_msg *msg)
   355	{
   356		struct acpi_ipmi_msg *tx_msg, *temp;
   357		unsigned long flags;
   358	
   359		spin_lock_irqsave(&ipmi->tx_msg_lock, flags);
   360		list_for_each_entry_safe(tx_msg, temp, &ipmi->tx_msg_list, head) {
   361			if (msg == tx_msg) {
   362				list_del(&tx_msg->head);
   363				break;
   364			}
   365		}
   366		spin_unlock_irqrestore(&ipmi->tx_msg_lock, flags);
   367	
   368		if (list_entry_is_head(tx_msg, &ipmi->tx_msg_list, head)
 > 369			return;
   370	
   371		acpi_ipmi_msg_put(tx_msg);
 > 372	}
   373	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org