[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46f9dc71-9640-71cf-e8b6-d0e4133766f3@amd.com>
Date: Fri, 11 Feb 2022 12:25:15 -0600
From: Terry Bowman <Terry.Bowman@....com>
To: Wolfram Sang <wsa@...nel.org>, Jean Delvare <jdelvare@...e.de>,
linux@...ck-us.net, linux-watchdog@...r.kernel.org,
linux-i2c@...r.kernel.org, andy.shevchenko@...il.com,
rafael.j.wysocki@...el.com, linux-kernel@...r.kernel.org,
wim@...ux-watchdog.org, rrichter@....com, thomas.lendacky@....com,
sudheesh.mavila@....com, Nehal-bakulchandra.Shah@....com,
Basavaraj.Natikar@....com, Shyam-sundar.S-k@....com,
Mario.Limonciello@....com
Subject: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release
code into functions
Hi Wolfram an Jean,
On 2/11/22 09:00, Terry Bowman wrote:
> Hi Wolfram and Jean,
>
> On 2/11/22 08:42, Wolfram Sang wrote:
>>>> + if (retval)
>>>
>>> Missing curly brace here, breaks the build.
>>
>> Bummer, need to check why this wasn't found by my build-testing.
>>
>> I fixed it up and also rebased patch 6 to my change. Terry, please have
>> a look that I did everything correctly once I push out later today.
>>
>> Thanks everyone!
>>
> I need to look at how I sent that out. I will look for the fix in
> i2c/for-next. Thanks for the help and review.
I verified the fix looks good. From commit a3325d225b00 on i2c/for-next:
@@ -373,11 +388,10 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
piix4_port_shift_sb800 = SB800_PIIX4_PORT_IDX_SHIFT;
}
} else {
- if (!request_muxed_region(SB800_PIIX4_SMB_IDX,
- SB800_PIIX4_SMB_MAP_SIZE,
- "sb800_piix4_smb")) {
+ retval = piix4_sb800_region_request(&PIIX4_dev->dev);
+ if (retval) {
release_region(piix4_smba, SMBIOSIZE);
- return -EBUSY;
+ return retval;
}
Powered by blists - more mailing lists