linux-kernel - Re: [PATCH] staging: pi433: add rf69_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yga3gHm0X5UlKuXv@mail.google.com>
Date:   Sat, 12 Feb 2022 08:22:40 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, realwakka@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: add rf69_dbg_hex function

thanks for taking the time to review my patch

On Fri, Feb 11, 2022 at 05:25:28PM +0300, Dan Carpenter wrote:
> 
> I feel like this patch is over engineering your debug code.  Is this
> really worthwhile?  If you really prefer the new format that's fine but
> it seems like not necessarily a good use of energy.
> 

After reflecting on it for while, I think that you and Greg are right
not to like the approach taken.

> > +	}
> 
> Instead of printing lineline at a time in a loop, what happens if you
> just print size bytes?  (I honestly don't know because I have never used
> this function before).
> 

It gets truncated as hex_dump_to_buffer prints at most 32 bytes.

thanks,

Paulo Almeida