linux-kernel - Re: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yga3oWKqg7TK6lWZ@zn.tnic>
Date:   Fri, 11 Feb 2022 20:23:13 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset

On Thu, Jan 27, 2022 at 08:40:53PM +0000, Yazen Ghannam wrote:
> @@ -1099,22 +1140,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr
>  	ctx.nid = nid;
>  	ctx.inst_id = umc;
>  
> -	/* Read D18F0x1B4 (DramOffset), check if base 1 is used. */
> -	if (df_indirect_read_instance(nid, 0, 0x1B4, umc, &ctx.tmp))
> +	if (remove_dram_offset(&ctx)) {
> +		pr_debug("Failed to remove DRAM offset");

You don't need that pr_debug - remove_dram_offset() already has one for
the single error case.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette