linux-kernel - Re: [PATCH] power: supply: ab8500: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Feb 2022 21:30:33 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     cgel.zte@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] power: supply: ab8500: remove unneeded variable

Hi,

On Fri, Jan 07, 2022 at 02:26:02AM +0000, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ab8500_fg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
> index b0919a6a6587..3927f4ad7c38 100644
> --- a/drivers/power/supply/ab8500_fg.c
> +++ b/drivers/power/supply/ab8500_fg.c
> @@ -3170,7 +3170,6 @@ static int ab8500_fg_probe(struct platform_device *pdev)
>  
>  static int ab8500_fg_remove(struct platform_device *pdev)
>  {
> -	int ret = 0;
>  	struct ab8500_fg *di = platform_get_drvdata(pdev);
>  
>  	component_del(&pdev->dev, &ab8500_fg_component_ops);
> @@ -3178,7 +3177,7 @@ static int ab8500_fg_remove(struct platform_device *pdev)
>  	ab8500_fg_sysfs_exit(di);
>  	ab8500_fg_sysfs_psy_remove_attrs(di);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static SIMPLE_DEV_PM_OPS(ab8500_fg_pm_ops, ab8500_fg_suspend, ab8500_fg_resume);
> -- 
> 2.25.1
>