linux-kernel - Re: [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ygbg+KYK9qT90O2N@heinlein>
Date:   Fri, 11 Feb 2022 16:19:36 -0600
From:   Patrick Williams <patrick@...cx.xyz>
To:     Potin Lai <potin.lai@...ntatw.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] arch: arm: dts: bletchley: cleanup redundant node

On Fri, Feb 11, 2022 at 09:43:47AM +0800, Potin Lai wrote:
> Remove redundant i2c1 node.
> Disable in-chip rtc, use external rtc (pcf85263) instead.

A bit of "why" on the RTC change might be useful.  I suspect it has to do
with where battery-backing is for the RTC in hardware.

> 
> Signed-off-by: Potin Lai <potin.lai@...ntatw.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> index 946107bd8bc7..fb62a67cfeed 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
> @@ -205,10 +205,6 @@
>  	};
>  };
>  
> -&rtc {
> -	status = "okay";
> -};
> -
>  &fmc {
>  	status = "okay";
>  	flash@0 {
> @@ -387,10 +383,6 @@
>  	};
>  };
>  
> -&i2c1 {
> -	status = "okay";
> -};
> -
>  &i2c2 {
>  	status = "okay";
>  	ina230@45 {
> @@ -680,6 +672,7 @@
>  	};
>  
>  	rtc@51 {
> +		/* in-chip rtc disabled, use this external rtc instead */
>  		compatible = "nxp,pcf85263";
>  		reg = <0x51>;
>  	};
> -- 
> 2.17.1
> 

-- 
Patrick Williams

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)