linux-kernel - Re: [PATCH] spi: Fix warning for Clang build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aaaefa2b-e043-2bf8-28aa-d89deb3fbc2a@redhat.com>
Date:   Thu, 10 Feb 2022 20:49:58 -0800
From:   Tom Rix <trix@...hat.com>
To:     Lh Kuo 郭力豪 <lh.Kuo@...plus.com>,
        Mark Brown <broonie@...nel.org>,
        Li-hao Kuo <lhjeff911@...il.com>
Cc:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: Re: [PATCH] spi: Fix warning for Clang build


On 2/10/22 7:32 PM, Lh Kuo 郭力豪 wrote:
>> The return here means that the initialization is now redundant and will stop the compiler spotting any
>> future similar issues which isn't ideal.
> I got it, so do I need to submit a new patch?

Assuming yes, so something else..

Looking again at the function, there are 3 sets of if-check blocks these 
could be combined into the first one.

The later two are variations on is this an rx or a tx, the first check 
does that.

T

>
>