linux-kernel - Re: [PATCH v2] input: Add Marine Navigation Keycodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Feb 2022 22:47:40 -0600
From:   Shelby Heffron <Shelby.Heffron@...min.com>
To:     <dmitry.torokhov@...il.com>, <linux-input@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] input: Add Marine Navigation Keycodes

Hello all,

On 1/26/2022 3:12 PM, Shelby Heffron wrote:
> Add keycodes that are used by marine navigation devices
> 
> Signed-off-by: Shelby Heffron <Shelby.Heffron@...min.com>
> ---
>   include/uapi/linux/input-event-codes.h | 28 ++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
> 
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 225ec87d4f22..26b6a2f482ab 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -660,6 +660,34 @@
>   /* Select an area of screen to be copied */
>   #define KEY_SELECTIVE_SCREENSHOT	0x27a
>   
> +/* Toggle the focus in or out */
> +#define KEY_FOCUS_TOGGLE		0x27b
> +
> +/* Move between highlightable items */
> +#define KEY_NEXT_HIGHLIGHT		0x27c
> +#define KEY_PREVIOUS_HIGHLIGHT		0x27d
> +
> +/* Toggle Autopilot enagement */
> +#define KEY_AUTOPILOT_ENGAGE_TOGGLE	0x27e
> +
> +/* Navigate Displays */
> +#define KEY_NEXT_DISPLAY		0x27f
> +#define KEY_PREVIOUS_DISPLAY		0x280
> +
> +/* Shortcut Keys */
> +#define KEY_MARK_WAYPOINT		0x281
> +#define KEY_SOS			0x282
> +#define KEY_NAV_CHART			0x283
> +#define KEY_FISHING_CHART		0x284
> +#define KEY_SINGLE_RANGE_RADAR		0x285
> +#define KEY_DUAL_RANGE_RADAR		0x286
> +#define KEY_RADAR_OVERLAY		0x287
> +#define KEY_TRADITIONAL_SONAR		0x288
> +#define KEY_CLEARVU_SONAR		0x289
> +#define KEY_SIDEVU_SONAR		0x28a
> +#define KEY_NAV_INFO			0x28b
> +#define KEY_BRIGHTNESS_MENU		0x28c

I am looking for some guidance on if this is the proper place for these 
keys to be defined? If not, or if they are too specific, do I have any 
other options?

Thanks.
Shelby

> +
>   /*
>    * Some keyboards have keys which do not have a defined meaning, these keys
>    * are intended to be programmed / bound to macros by the user. For most