linux-kernel - Re: [PATCH v2 2/2] Input: add Imagis touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220211005041.GA51878@nixie71>
Date:   Thu, 10 Feb 2022 18:50:41 -0600
From:   Jeff LaBundy <jeff@...undy.com>
To:     Markuss Broks <markuss.broks@...il.com>
Cc:     linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Henrik Rydberg <rydberg@...math.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Input: add Imagis touchscreen driver

Hi Markuss,

One tiny correction to my previous feedback.

On Thu, Feb 10, 2022 at 06:01:03PM -0600, Jeff LaBundy wrote:
> Hi Markuss,
> 
> Neat little driver! Some humble feedback below.
> 

[...]

> > +	error = input_register_device(input_dev);
> > +	if (error) {
> > +		dev_err(&ts->client->dev,
> > +			"Failed to register input device: %d", error);
> > +		return error;
> > +	}
> 
> I suggest using the device-managed version here, as you have no remove callback.
> 

Please ignore this bit :)

[...]

Kind regards,
Jeff LaBundy