| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Feb 2022 08:57:56 -0600
From: Rob Herring <robh@...nel.org>
To: Vidya Sagar <vidyas@...dia.com>
Cc: bhelgaas@...gle.com, lorenzo.pieralisi@....com,
thierry.reding@...il.com, jonathanh@...dia.com, kishon@...com,
vkoul@...nel.org, kw@...ux.com, krzysztof.kozlowski@...onical.com,
p.zabel@...gutronix.de, mperttunen@...dia.com,
linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-phy@...ts.infradead.org, kthota@...dia.com,
mmaddireddy@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V1 05/10] dt-bindings: PCI: tegra: Add device tree
support for Tegra234
On Sat, Feb 05, 2022 at 09:51:39PM +0530, Vidya Sagar wrote:
> Add support for Tegra234 PCIe controllers. These controllers are based
> on Synopsys DesignWare core IP.
>
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
> .../bindings/pci/nvidia,tegra194-pcie.txt | 106 +++++++++++++++++-
> 1 file changed, 103 insertions(+), 3 deletions(-)
This falls above my threshold of convert this to schema first.
>
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt
> index 8e4f9bfb316d..ae9555a50fb0 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt
> @@ -10,6 +10,8 @@ Required properties:
> - power-domains: A phandle to the node that controls power to the respective
> PCIe controller and a specifier name for the PCIe controller. Following are
> the specifiers for the different PCIe controllers
> + Tegra194:
> + ---------
> TEGRA194_POWER_DOMAIN_PCIEX8B: C0
> TEGRA194_POWER_DOMAIN_PCIEX1A: C1
> TEGRA194_POWER_DOMAIN_PCIEX1A: C2
> @@ -18,6 +20,21 @@ Required properties:
> TEGRA194_POWER_DOMAIN_PCIEX8A: C5
> these specifiers are defined in
> "include/dt-bindings/power/tegra194-powergate.h" file.
> + Tegra234:
> + ---------
> + TEGRA234_POWER_DOMAIN_PCIEX4BA: C0
> + TEGRA234_POWER_DOMAIN_PCIEX1A : C1
> + TEGRA234_POWER_DOMAIN_PCIEX1A : C2
> + TEGRA234_POWER_DOMAIN_PCIEX1A : C3
> + TEGRA234_POWER_DOMAIN_PCIEX4BB: C4
> + TEGRA234_POWER_DOMAIN_PCIEX8A : C5
> + TEGRA234_POWER_DOMAIN_PCIEX4A : C6
> + TEGRA234_POWER_DOMAIN_PCIEX8B : C7
> + TEGRA234_POWER_DOMAIN_PCIEX4CA: C8
> + TEGRA234_POWER_DOMAIN_PCIEX4CB: C9
> + TEGRA234_POWER_DOMAIN_PCIEX4CC: C10
> + these specifiers are defined in
> + "include/dt-bindings/power/tegra234-powergate.h" file.
> - reg: A list of physical base address and length pairs for each set of
> controller registers. Must contain an entry for each entry in the reg-names
> property.
> @@ -47,16 +64,33 @@ Required properties:
> "p2u-N": where N ranges from 0 to one less than the total number of lanes
> - nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed
> by controller-id. Following are the controller ids for each controller.
> + Tegra194:
> + ---------
> 0: C0
> 1: C1
> 2: C2
> 3: C3
> 4: C4
> 5: C5
> + Tegra194:
> + ---------
> + 0 : C0
> + 1 : C1
> + 2 : C2
> + 3 : C3
> + 4 : C4
> + 5 : C5
> + 6 : C6
> + 7 : C7
> + 8 : C8
> + 9 : C9
> + 10: C10
> - vddio-pex-ctl-supply: Regulator supply for PCIe side band signals
>
> RC mode:
> -- compatible: Tegra19x must contain "nvidia,tegra194-pcie"
> +- compatible: Must be
> + - "nvidia,tegra194-pcie" for Tegra194
> + - "nvidia,tegra234-pcie" for Tegra234
> - device_type: Must be "pci" for RC mode
> - interrupt-names: Must include the following entries:
> "msi": The Tegra interrupt that is asserted when an MSI is received
> @@ -99,7 +133,8 @@ In Tegra194, Only controllers C0, C4 & C5 support EP mode.
>
> Optional properties:
> - pinctrl-names: A list of pinctrl state names.
> - It is mandatory for C5 controller and optional for other controllers.
> + It is mandatory for C5 controller in Tegra194 and optional for other
> + controllers.
> - "default": Configures PCIe I/O for proper operation.
> - pinctrl-0: phandle for the 'default' state of pin configuration.
> It is mandatory for C5 controller and optional for other controllers.
> @@ -108,7 +143,7 @@ Optional properties:
> improve performance when a platform is designed in such a way that it
> satisfies at least one of the following conditions thereby enabling root
> port to exchange optimum number of FC (Flow Control) credits with
> - downstream devices
> + downstream devices. This is applicable for only Tegra194.
> 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS)
> 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and
> a) speed is Gen-2 and MPS is 256B
> @@ -119,6 +154,9 @@ Optional properties:
> specified in microseconds
> - nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be
> specified in microseconds
> +- nvidia,enable-srns: This boolean property needs to be present if the
> + controller is configured to operate in SRNS (Separate Reference Clocks with
> + No Spread-Spectrum Clocking). This is applicable only for Tegra234.
>
> RC mode:
> - vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot
> @@ -127,6 +165,9 @@ RC mode:
> - vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot
> if the platform has one such slot. (Ex:- x16 slot owned by C5 controller
> in p2972-0000 platform).
> +- nvidia,enable-ext-refclk: This boolean property needs to be present if the
> + controller is configured to use the reference clocking coming in from an
> + external clock source instead of using the internal clock source.
>
> EP mode:
> - nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller
> @@ -243,3 +284,62 @@ Tegra194 EP mode:
> phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4",
> "p2u-5", "p2u-6", "p2u-7";
> };
> +
> +Tegra234 RP mode:
> +-----------------
> +
> + pcie@...a0000 {
> + compatible = "nvidia,tegra234-pcie";
> + power-domains = <&bpmp TEGRA234_POWER_DOMAIN_PCIEX8A>;
> + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */
> + <0x00 0x3a000000 0x0 0x00040000>, /* configuration space (256K) */
> + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */
> + <0x00 0x3a080000 0x0 0x00040000>; /* DBI reg space (256K) */
> + reg-names = "appl", "config", "atu_dma", "dbi";
> +
> + status = "disabled";
Why is your example disabled?
> +
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + num-lanes = <8>;
> + num-viewport = <8>;
> + linux,pci-domain = <5>;
> +
> + clocks = <&bpmp TEGRA234_CLK_PEX1_C5_CORE>;
> + clock-names = "core";
> +
> + resets = <&bpmp TEGRA234_RESET_PEX1_CORE_5_APB>,
> + <&bpmp TEGRA234_RESET_PEX1_CORE_5>;
> + reset-names = "apb", "core";
> +
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */
> + <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */
> + interrupt-names = "intr", "msi";
> +
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0 0 0 0>;
> + interrupt-map = <0 0 0 0 &gic GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> +
> + nvidia,bpmp = <&bpmp 5>;
> +
> + nvidia,aspm-cmrt-us = <60>;
> + nvidia,aspm-pwr-on-t-us = <20>;
> + nvidia,aspm-l0s-entrance-latency-us = <3>;
> +
> + bus-range = <0x0 0xff>;
> +
> + ranges = <0x43000000 0x27 0x40000000 0x27 0x40000000 0x3 0xe8000000>, /* prefetchable memory (16000 MB) */
> + <0x02000000 0x0 0x40000000 0x2b 0x28000000 0x0 0x08000000>, /* non-prefetchable memory (128 MB) */
> + <0x01000000 0x0 0x3a100000 0x00 0x3a100000 0x0 0x00100000>; /* downstream I/O (1 MB) */
> +
> + interconnects = <&mc TEGRA234_MEMORY_CLIENT_PCIE5R &emc>,
> + <&mc TEGRA234_MEMORY_CLIENT_PCIE5W &emc>;
> + interconnect-names = "dma-mem", "write";
> +
> + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>,
> + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>,
> + <&p2u_nvhs_6>, <&p2u_nvhs_7>;
> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4",
> + "p2u-5", "p2u-6", "p2u-7";
> + };
> --
> 2.17.1
>
>
Powered by blists - more mailing lists