linux-kernel - Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a89a99872ff2fd67f097224584121e50b8a2f07.camel@apitzsch.eu>
Date:   Sat, 12 Feb 2022 14:13:32 +0100
From:   André Apitzsch <git@...tzsch.eu>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-leds@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: leds: sgm3140: Document ocp8110
 compatible

Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> 
> Commit msg? What's this h/w?
> 
Thanks for the feedback.

Would the following message be sufficient?

"""
dt-bindings: leds: sgm3140: Document ocp8110 compatible

Add devicetree binding for Orient Chip OCP8110 charge pump used for
camera flash LEDs.
"""

> > ---
> >  Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index f68259619488..1c345cf16d08 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -18,7 +18,9 @@ description: |
> >  
> >  properties:
> >    compatible:
> > -    const: sgmicro,sgm3140
> > +    enum:
> > +      - ocs,ocp8110
> > +      - sgmicro,sgm3140
> >  
> >    enable-gpios:
> >      maxItems: 1
> > -- 
> > 2.35.1
> > 
> >