linux-kernel - Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Feb 2022 19:23:38 +0100
From:   Salvatore Bonaccorso <carnil@...ian.org>
To:     Alex Deucher <alexander.deucher@....com>
Cc:     Dominique Dumont <dod@...ian.org>, 1005005@...s.debian.org,
        Luben Tuikov <luben.tuikov@....com>,
        Evan Quan <evan.quan@....com>, Sasha Levin <sashal@...nel.org>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in
 suspend (v2)") on suspend?

Hi Alex, hi all

In Debian we got a regression report from Dominique Dumont, CC'ed in
https://bugs.debian.org/1005005 that afer an update to 5.15.15 based
kernel, his machine noe longer suspends correctly, after screen going
black as usual it comes back. The Debian bug above contians a trace.

Dominique confirmed that this issue persisted after updating to 5.16.7
furthermore he bisected the issue and found 

	3c196f05666610912645c7c5d9107706003f67c3 is the first bad commit
	commit 3c196f05666610912645c7c5d9107706003f67c3
	Author: Alex Deucher <alexander.deucher@....com>
	Date:   Fri Nov 12 11:25:30 2021 -0500

	    drm/amdgpu: always reset the asic in suspend (v2)

	    [ Upstream commit daf8de0874ab5b74b38a38726fdd3d07ef98a7ee ]

	    If the platform suspend happens to fail and the power rail
	    is not turned off, the GPU will be in an unknown state on
	    resume, so reset the asic so that it will be in a known
	    good state on resume even if the platform suspend failed.

	    v2: handle s0ix

	    Acked-by: Luben Tuikov <luben.tuikov@....com>
	    Acked-by: Evan Quan <evan.quan@....com>
	    Signed-off-by: Alex Deucher <alexander.deucher@....com>
	    Signed-off-by: Sasha Levin <sashal@...nel.org>

	 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++-
	 1 file changed, 4 insertions(+), 1 deletion(-)

to be the first bad commit, see https://bugs.debian.org/1005005#34 .

Does this ring any bell? Any idea on the problem?

Regards,
Salvatore