linux-kernel - [nbd168-wireless:mtk-flow-offload 9/9] drivers/net/wireless/mediatek/mt76/mt7915/mac.c:1414:28: warning: variable 'phy' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 12 Feb 2022 13:24:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Felix Fietkau <nbd@....name>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [nbd168-wireless:mtk-flow-offload 9/9]
 drivers/net/wireless/mediatek/mt76/mt7915/mac.c:1414:28: warning: variable
 'phy' set but not used

tree:   https://github.com/nbd168/wireless mtk-flow-offload
head:   1ba2137278dd5c4747b6e43be7aae4e94fb9c76e
commit: 1ba2137278dd5c4747b6e43be7aae4e94fb9c76e [9/9] mt76: mt7915: add Wireless Ethernet Dispatch support
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220212/202202121320.bRZMLlj6-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/nbd168/wireless/commit/1ba2137278dd5c4747b6e43be7aae4e94fb9c76e
        git remote add nbd168-wireless https://github.com/nbd168/wireless
        git fetch --no-tags nbd168-wireless mtk-flow-offload
        git checkout 1ba2137278dd5c4747b6e43be7aae4e94fb9c76e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/wireless/mediatek/mt76/mt7915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/mediatek/mt76/mt7915/mac.c: In function 'mt7915_txwi_free':
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c:1414:28: warning: variable 'phy' set but not used [-Wunused-but-set-variable]
    1414 |         struct mt7915_phy *phy;
         |                            ^~~


vim +/phy +1414 drivers/net/wireless/mediatek/mt76/mt7915/mac.c

  1407	
  1408	static void
  1409	mt7915_txwi_free(struct mt7915_dev *dev, struct mt76_txwi_cache *t,
  1410			 struct ieee80211_sta *sta, struct list_head *free_list)
  1411	{
  1412		struct mt76_dev *mdev = &dev->mt76;
  1413		struct mt7915_sta *msta;
> 1414		struct mt7915_phy *phy;
  1415		struct mt76_wcid *wcid;
  1416		__le32 *txwi;
  1417		u16 wcid_idx;
  1418	
  1419		mt7915_txp_skb_unmap(mdev, t);
  1420		if (!t->skb)
  1421			goto out;
  1422	
  1423		txwi = (__le32 *)mt76_get_txwi_ptr(mdev, t);
  1424		if (sta) {
  1425			wcid = (struct mt76_wcid *)sta->drv_priv;
  1426			wcid_idx = wcid->idx;
  1427		} else {
  1428			wcid_idx = FIELD_GET(MT_TXD1_WLAN_IDX, le32_to_cpu(txwi[1]));
  1429			wcid = rcu_dereference(dev->mt76.wcid[wcid_idx]);
  1430	
  1431			if (wcid && wcid->sta) {
  1432				msta = container_of(wcid, struct mt7915_sta, wcid);
  1433				sta = container_of((void *)msta, struct ieee80211_sta,
  1434						  drv_priv);
  1435				phy = msta->vif->phy;
  1436				spin_lock_bh(&dev->sta_poll_lock);
  1437				if (list_empty(&msta->poll_list))
  1438					list_add_tail(&msta->poll_list, &dev->sta_poll_list);
  1439				spin_unlock_bh(&dev->sta_poll_lock);
  1440			}
  1441		}
  1442	
  1443		if (sta && likely(t->skb->protocol != cpu_to_be16(ETH_P_PAE)))
  1444			mt7915_tx_check_aggr(sta, txwi);
  1445	
  1446		__mt76_tx_complete_skb(mdev, wcid_idx, t->skb, free_list);
  1447	
  1448	out:
  1449		t->skb = NULL;
  1450		mt76_put_txwi(mdev, t);
  1451	}
  1452	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org