| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Feb 2022 13:35:02 +0800
From: kernel test robot <lkp@...el.com>
To: Omar Sandoval <osandov@...com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
David Sterba <dsterba@...e.com>,
Nikolay Borisov <nborisov@...e.com>,
Josef Bacik <josef@...icpanda.com>
Subject: [kdave-btrfs-devel:for-next 79/93] fs/btrfs/ordered-data.c:168:
warning: expecting prototype for Add an ordered extent to the per().
Prototype was for btrfs_add_ordered_extent() instead
tree: https://github.com/kdave/btrfs-devel.git for-next
head: 57b409a8644b7c0f8974ff16b3a5e231cccc3ec3
commit: acfd26ee6a09af2a5c347978407fddcd8819e534 [79/93] btrfs: add ram_bytes and offset to btrfs_ordered_extent
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220212/202202121310.oqkfnupw-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/kdave/btrfs-devel/commit/acfd26ee6a09af2a5c347978407fddcd8819e534
git remote add kdave-btrfs-devel https://github.com/kdave/btrfs-devel.git
git fetch --no-tags kdave-btrfs-devel for-next
git checkout acfd26ee6a09af2a5c347978407fddcd8819e534
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash fs/btrfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> fs/btrfs/ordered-data.c:168: warning: expecting prototype for Add an ordered extent to the per(). Prototype was for btrfs_add_ordered_extent() instead
vim +168 fs/btrfs/ordered-data.c
dc17ff8f11d129 Chris Mason 2008-01-08 145
acfd26ee6a09af Omar Sandoval 2019-11-06 146 /**
acfd26ee6a09af Omar Sandoval 2019-11-06 147 * Add an ordered extent to the per-inode tree.
acfd26ee6a09af Omar Sandoval 2019-11-06 148 *
acfd26ee6a09af Omar Sandoval 2019-11-06 149 * @inode: Inode that this extent is for.
acfd26ee6a09af Omar Sandoval 2019-11-06 150 * @file_offset: Logical offset in file where the extent starts.
acfd26ee6a09af Omar Sandoval 2019-11-06 151 * @num_bytes: Logical length of extent in file.
acfd26ee6a09af Omar Sandoval 2019-11-06 152 * @ram_bytes: Full length of unencoded data.
acfd26ee6a09af Omar Sandoval 2019-11-06 153 * @disk_bytenr: Offset of extent on disk.
acfd26ee6a09af Omar Sandoval 2019-11-06 154 * @disk_num_bytes: Size of extent on disk.
acfd26ee6a09af Omar Sandoval 2019-11-06 155 * @offset: Offset into unencoded data where file data starts.
acfd26ee6a09af Omar Sandoval 2019-11-06 156 * @flags: Flags specifying type of extent (1 << BTRFS_ORDERED_*).
acfd26ee6a09af Omar Sandoval 2019-11-06 157 * @compress_type: Compression algorithm used for data.
acfd26ee6a09af Omar Sandoval 2019-11-06 158 *
acfd26ee6a09af Omar Sandoval 2019-11-06 159 * Most of these parameters correspond to &struct btrfs_file_extent_item. The
acfd26ee6a09af Omar Sandoval 2019-11-06 160 * tree is given a single reference on the ordered extent that was inserted.
eb84ae039e10f1 Chris Mason 2008-07-17 161 *
acfd26ee6a09af Omar Sandoval 2019-11-06 162 * Return: 0 or -ENOMEM.
eb84ae039e10f1 Chris Mason 2008-07-17 163 */
acfd26ee6a09af Omar Sandoval 2019-11-06 164 int btrfs_add_ordered_extent(struct btrfs_inode *inode, u64 file_offset,
acfd26ee6a09af Omar Sandoval 2019-11-06 165 u64 num_bytes, u64 ram_bytes, u64 disk_bytenr,
acfd26ee6a09af Omar Sandoval 2019-11-06 166 u64 disk_num_bytes, u64 offset, unsigned flags,
bffe633e00fb6b Omar Sandoval 2019-12-02 167 int compress_type)
dc17ff8f11d129 Chris Mason 2008-01-08 @168 {
da69fea9f785d8 Nikolay Borisov 2020-06-03 169 struct btrfs_root *root = inode->root;
da69fea9f785d8 Nikolay Borisov 2020-06-03 170 struct btrfs_fs_info *fs_info = root->fs_info;
da69fea9f785d8 Nikolay Borisov 2020-06-03 171 struct btrfs_ordered_inode_tree *tree = &inode->ordered_tree;
e6dcd2dc9c4891 Chris Mason 2008-07-17 172 struct rb_node *node;
e6dcd2dc9c4891 Chris Mason 2008-07-17 173 struct btrfs_ordered_extent *entry;
7dbeaad0af7d0a Qu Wenruo 2020-06-10 174 int ret;
dc17ff8f11d129 Chris Mason 2008-01-08 175
acfd26ee6a09af Omar Sandoval 2019-11-06 176 if (flags &
acfd26ee6a09af Omar Sandoval 2019-11-06 177 ((1 << BTRFS_ORDERED_NOCOW) | (1 << BTRFS_ORDERED_PREALLOC))) {
7dbeaad0af7d0a Qu Wenruo 2020-06-10 178 /* For nocow write, we can release the qgroup rsv right now */
8b8a979f1fc690 Nikolay Borisov 2020-06-03 179 ret = btrfs_qgroup_free_data(inode, NULL, file_offset, num_bytes);
7dbeaad0af7d0a Qu Wenruo 2020-06-10 180 if (ret < 0)
7dbeaad0af7d0a Qu Wenruo 2020-06-10 181 return ret;
7dbeaad0af7d0a Qu Wenruo 2020-06-10 182 ret = 0;
7dbeaad0af7d0a Qu Wenruo 2020-06-10 183 } else {
7dbeaad0af7d0a Qu Wenruo 2020-06-10 184 /*
7dbeaad0af7d0a Qu Wenruo 2020-06-10 185 * The ordered extent has reserved qgroup space, release now
7dbeaad0af7d0a Qu Wenruo 2020-06-10 186 * and pass the reserved number for qgroup_record to free.
7dbeaad0af7d0a Qu Wenruo 2020-06-10 187 */
72b7d15bf1e1ee Nikolay Borisov 2020-06-03 188 ret = btrfs_qgroup_release_data(inode, file_offset, num_bytes);
7dbeaad0af7d0a Qu Wenruo 2020-06-10 189 if (ret < 0)
7dbeaad0af7d0a Qu Wenruo 2020-06-10 190 return ret;
7dbeaad0af7d0a Qu Wenruo 2020-06-10 191 }
6352b91da1a210 Miao Xie 2012-09-06 192 entry = kmem_cache_zalloc(btrfs_ordered_extent_cache, GFP_NOFS);
dc17ff8f11d129 Chris Mason 2008-01-08 193 if (!entry)
dc17ff8f11d129 Chris Mason 2008-01-08 194 return -ENOMEM;
dc17ff8f11d129 Chris Mason 2008-01-08 195
e6dcd2dc9c4891 Chris Mason 2008-07-17 196 entry->file_offset = file_offset;
bffe633e00fb6b Omar Sandoval 2019-12-02 197 entry->num_bytes = num_bytes;
acfd26ee6a09af Omar Sandoval 2019-11-06 198 entry->ram_bytes = ram_bytes;
acfd26ee6a09af Omar Sandoval 2019-11-06 199 entry->disk_bytenr = disk_bytenr;
bffe633e00fb6b Omar Sandoval 2019-12-02 200 entry->disk_num_bytes = disk_num_bytes;
acfd26ee6a09af Omar Sandoval 2019-11-06 201 entry->offset = offset;
bffe633e00fb6b Omar Sandoval 2019-12-02 202 entry->bytes_left = num_bytes;
da69fea9f785d8 Nikolay Borisov 2020-06-03 203 entry->inode = igrab(&inode->vfs_inode);
261507a02ccba9 Li Zefan 2010-12-17 204 entry->compress_type = compress_type;
77cef2ec548456 Josef Bacik 2013-08-29 205 entry->truncated_len = (u64)-1;
7dbeaad0af7d0a Qu Wenruo 2020-06-10 206 entry->qgroup_rsv = ret;
d8e3fb106f3938 Naohiro Aota 2021-02-04 207 entry->physical = (u64)-1;
3c198fe064491d Qu Wenruo 2021-01-21 208
acfd26ee6a09af Omar Sandoval 2019-11-06 209 ASSERT((flags & ~BTRFS_ORDERED_TYPE_FLAGS) == 0);
acfd26ee6a09af Omar Sandoval 2019-11-06 210 entry->flags = flags;
3eaa2885276fd6 Chris Mason 2008-07-24 211
5deb17e18e27a3 Josef Bacik 2020-10-09 212 percpu_counter_add_batch(&fs_info->ordered_bytes, num_bytes,
4297ff84dc24d1 Josef Bacik 2019-04-10 213 fs_info->delalloc_batch);
5deb17e18e27a3 Josef Bacik 2020-10-09 214
e6dcd2dc9c4891 Chris Mason 2008-07-17 215 /* one ref for the tree */
e76edab7f059bc Elena Reshetova 2017-03-03 216 refcount_set(&entry->refs, 1);
e6dcd2dc9c4891 Chris Mason 2008-07-17 217 init_waitqueue_head(&entry->wait);
e6dcd2dc9c4891 Chris Mason 2008-07-17 218 INIT_LIST_HEAD(&entry->list);
487781796d3022 Filipe Manana 2020-08-11 219 INIT_LIST_HEAD(&entry->log_list);
3eaa2885276fd6 Chris Mason 2008-07-24 220 INIT_LIST_HEAD(&entry->root_extent_list);
9afab8820bb8b5 Miao Xie 2012-10-25 221 INIT_LIST_HEAD(&entry->work_list);
9afab8820bb8b5 Miao Xie 2012-10-25 222 init_completion(&entry->completion);
dc17ff8f11d129 Chris Mason 2008-01-08 223
acbf1dd0fcbd10 Nikolay Borisov 2020-08-31 224 trace_btrfs_ordered_extent_add(inode, entry);
1abe9b8a138c99 liubo 2011-03-24 225
5fd02043553b02 Josef Bacik 2012-05-02 226 spin_lock_irq(&tree->lock);
e6dcd2dc9c4891 Chris Mason 2008-07-17 227 node = tree_insert(&tree->tree, file_offset,
e6dcd2dc9c4891 Chris Mason 2008-07-17 228 &entry->rb_node);
43c04fb1b8c9f4 Jeff Mahoney 2011-10-03 229 if (node)
511a32b5493f0d Nikolay Borisov 2019-11-29 230 btrfs_panic(fs_info, -EEXIST,
511a32b5493f0d Nikolay Borisov 2019-11-29 231 "inconsistency in ordered tree at offset %llu",
511a32b5493f0d Nikolay Borisov 2019-11-29 232 file_offset);
5fd02043553b02 Josef Bacik 2012-05-02 233 spin_unlock_irq(&tree->lock);
d397712bcc6a75 Chris Mason 2009-01-05 234
199c2a9c3d1389 Miao Xie 2013-05-15 235 spin_lock(&root->ordered_extent_lock);
3eaa2885276fd6 Chris Mason 2008-07-24 236 list_add_tail(&entry->root_extent_list,
199c2a9c3d1389 Miao Xie 2013-05-15 237 &root->ordered_extents);
199c2a9c3d1389 Miao Xie 2013-05-15 238 root->nr_ordered_extents++;
199c2a9c3d1389 Miao Xie 2013-05-15 239 if (root->nr_ordered_extents == 1) {
0b246afa62b0cf Jeff Mahoney 2016-06-22 240 spin_lock(&fs_info->ordered_root_lock);
199c2a9c3d1389 Miao Xie 2013-05-15 241 BUG_ON(!list_empty(&root->ordered_root));
0b246afa62b0cf Jeff Mahoney 2016-06-22 242 list_add_tail(&root->ordered_root, &fs_info->ordered_roots);
0b246afa62b0cf Jeff Mahoney 2016-06-22 243 spin_unlock(&fs_info->ordered_root_lock);
199c2a9c3d1389 Miao Xie 2013-05-15 244 }
199c2a9c3d1389 Miao Xie 2013-05-15 245 spin_unlock(&root->ordered_extent_lock);
3eaa2885276fd6 Chris Mason 2008-07-24 246
8b62f87bad9cf0 Josef Bacik 2017-10-19 247 /*
8b62f87bad9cf0 Josef Bacik 2017-10-19 248 * We don't need the count_max_extents here, we can assume that all of
8b62f87bad9cf0 Josef Bacik 2017-10-19 249 * that work has been done at higher layers, so this is truly the
8b62f87bad9cf0 Josef Bacik 2017-10-19 250 * smallest the extent is going to get.
8b62f87bad9cf0 Josef Bacik 2017-10-19 251 */
da69fea9f785d8 Nikolay Borisov 2020-06-03 252 spin_lock(&inode->lock);
da69fea9f785d8 Nikolay Borisov 2020-06-03 253 btrfs_mod_outstanding_extents(inode, 1);
da69fea9f785d8 Nikolay Borisov 2020-06-03 254 spin_unlock(&inode->lock);
8b62f87bad9cf0 Josef Bacik 2017-10-19 255
dc17ff8f11d129 Chris Mason 2008-01-08 256 return 0;
dc17ff8f11d129 Chris Mason 2008-01-08 257 }
dc17ff8f11d129 Chris Mason 2008-01-08 258
:::::: The code at line 168 was first introduced by commit
:::::: dc17ff8f11d129db9e83ab7244769e4eae05e14d Btrfs: Add data=ordered support
:::::: TO: Chris Mason <chris.mason@...cle.com>
:::::: CC: Chris Mason <chris.mason@...cle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists