linux-kernel - Re: [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220213152807.GA4073956@roeck-us.net>
Date:   Sun, 13 Feb 2022 07:28:07 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mateusz Jończyk <mat.jonczyk@...pl>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, x86@...nel.org,
        Pali Rohár <pali@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Mark Gross <markgross@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description

On Sat, Feb 12, 2022 at 01:56:54PM +0100, Mateusz Jończyk wrote:
> It is not the laptops, but the /proc/i8k interface that is legacy (or so
> I think was the intention of the help text author). The old description
> was confusing, fix this.
> 
> The phrase "Say Y if you intend to run this kernel on old Dell laptops
> or want to use userspace package i8kutils." was introduced in 2015, in
> commit 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
> 
> I think that "old laptops" was about hotkey and Fn key support - this
> driver in the 2.4 kernels' era apparently had these capabilities
> (see: https://github.com/vitorafsr/i8kutils , description of
> "repeat_rate" kernel module parameter).
> 
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@...pl>
> Cc: Pali Rohár <pali@...nel.org>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Mark Gross <markgross@...nel.org>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> v2:
>   - help text language fixes (thanks: Randy Dunlap),
>   - modify commit description.
> ---
>  drivers/hwmon/Kconfig | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 1ee4e5eff567..39aeecc72800 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -506,19 +506,18 @@ config SENSORS_DELL_SMM
>  	  userspace interface for i8kutils package.
>  
>  config I8K
> -	bool "Dell i8k legacy laptop support"
> +	bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver"
>  	depends on SENSORS_DELL_SMM
>  	depends on PROC_FS
>  	help
> -	  This option enables legacy /proc/i8k userspace interface in hwmon
> -	  dell-smm-hwmon driver. Character file /proc/i8k reports bios version,
> -	  temperature and allows controlling fan speeds of Dell laptops via
> -	  System Management Mode. For old Dell laptops (like Dell Inspiron 8000)
> -	  it reports also power and hotkey status. For fan speed control is
> -	  needed userspace package i8kutils.
> +	  This option enables the legacy /proc/i8k userspace interface of the
> +	  dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS
> +	  version, temperatures and allows control of fan speeds of some Dell
> +	  laptops. Sometimes it also reports power and hotkey status.
>  
> -	  Say Y if you intend to run this kernel on old Dell laptops or want to
> -	  use userspace package i8kutils.
> +	  This interface is required to run programs from the i8kutils package.
> +
> +	  Say Y if you intend to run userspace programs that use this interface.
>  	  Say N otherwise.
>  
>  config SENSORS_DA9052_ADC