linux-kernel - Re: [PATCH 1/1] csky: Fixup compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98208fa3-4b28-cdeb-7699-dbd9d66bfa60@infradead.org>
Date:   Sun, 13 Feb 2022 08:00:16 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     wonder_rock@....com, guoren@...nel.org
Cc:     axboe@...nel.dk, linux-csky@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] csky: Fixup compile warning

Hi,


On 2/13/22 06:28, wonder_rock@....com wrote:
> From: Deyan Wang <wonder_rock@....com>
> 
> arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> arch/csky/kernel/process.c: 5 linux/version.h not needed.
> arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
> 
> Signed-off-by: Deyan Wang <wonder_rock@....com>

The patch makes sense but these are not compile warnings.
They come from scripts/checkversion.pl, which can be called
by 'make versioncheck', so I suppose that something in your
build system is running 'make versioncheck'.

You could just say "csky: fix versioncheck warnings"


> ---
>  arch/csky/include/asm/io.h | 1 -
>  arch/csky/kernel/process.c | 1 -
>  arch/csky/mm/dma-mapping.c | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f82654053dc0..ed53f0b47388 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>  
>  #include <linux/pgtable.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  
>  /*
>   * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22cd0e2..5de04707aa07 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>  
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/sched.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a7e8f9..82447029feb4 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/scatterlist.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <asm/cache.h>
>  
>  static inline void cache_op(phys_addr_t paddr, size_t size,

-- 
~Randy