lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 13 Feb 2022 11:02:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [arnd-playground:set_fs 6/11] arch/nios2/kernel/signal.c:109:14:
 sparse: sparse: incorrect type in argument 1 (different address spaces)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git set_fs
head:   0a081326831928b0d739bce68b8c0f9138b9c8ba
commit: a954036380ae20dbfa0c203bf6cafb21d1f3cedd [6/11] uaccess: generalize access_ok()
config: nios2-randconfig-s031-20220213 (https://download.01.org/0day-ci/archive/20220213/202202131038.l60bQPlc-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commit/?id=a954036380ae20dbfa0c203bf6cafb21d1f3cedd
        git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
        git fetch --no-tags arnd-playground set_fs
        git checkout a954036380ae20dbfa0c203bf6cafb21d1f3cedd
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> arch/nios2/kernel/signal.c:109:14: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const [noderef] __user *ptr @@     got struct rt_sigframe *frame @@
   arch/nios2/kernel/signal.c:109:14: sparse:     expected void const [noderef] __user *ptr
   arch/nios2/kernel/signal.c:109:14: sparse:     got struct rt_sigframe *frame
   arch/nios2/kernel/signal.c:112:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got struct sigset_t * @@
   arch/nios2/kernel/signal.c:112:37: sparse:     expected void const [noderef] __user *from
   arch/nios2/kernel/signal.c:112:37: sparse:     got struct sigset_t *
   arch/nios2/kernel/signal.c:189:46: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct siginfo [noderef] [usertype] __user *to @@     got struct siginfo * @@
   arch/nios2/kernel/signal.c:189:46: sparse:     expected struct siginfo [noderef] [usertype] __user *to
   arch/nios2/kernel/signal.c:189:46: sparse:     got struct siginfo *
   arch/nios2/kernel/signal.c:192:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long [noderef] __user *__pu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:192:16: sparse:     expected unsigned long [noderef] __user *__pu_ptr
   arch/nios2/kernel/signal.c:192:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:193:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct ucontext *[noderef] __user *__pu_ptr @@     got struct ucontext ** @@
   arch/nios2/kernel/signal.c:193:16: sparse:     expected struct ucontext *[noderef] __user *__pu_ptr
   arch/nios2/kernel/signal.c:193:16: sparse:     got struct ucontext **
   arch/nios2/kernel/signal.c:194:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sigaltstack [noderef] [usertype] __user * @@     got struct sigaltstack * @@
   arch/nios2/kernel/signal.c:194:33: sparse:     expected struct sigaltstack [noderef] [usertype] __user *
   arch/nios2/kernel/signal.c:194:33: sparse:     got struct sigaltstack *
   arch/nios2/kernel/signal.c:196:30: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __user *to @@     got struct sigset_t * @@
   arch/nios2/kernel/signal.c:196:30: sparse:     expected void [noderef] __user *to
   arch/nios2/kernel/signal.c:196:30: sparse:     got struct sigset_t *
   arch/nios2/kernel/signal.c:48:15: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected int const [noderef] __user *__gu_ptr @@     got int * @@
   arch/nios2/kernel/signal.c:48:15: sparse:     expected int const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:48:15: sparse:     got int *
   arch/nios2/kernel/signal.c:52:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:52:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:52:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:53:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:53:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:53:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:54:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:54:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:54:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:55:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:55:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:55:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:56:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:56:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:56:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:57:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:57:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:57:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:58:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:58:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:58:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:59:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:59:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:59:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:60:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:60:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:60:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:61:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:61:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:61:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:62:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:62:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:62:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:63:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:63:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:63:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:64:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:64:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:64:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:65:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:65:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:65:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:66:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:66:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:66:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:67:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:67:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:67:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:68:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:68:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:68:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:69:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:69:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:69:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:70:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:70:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:70:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:71:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:71:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:71:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:72:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:72:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:72:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:73:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:73:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:73:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:74:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:74:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:74:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:76:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:76:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:76:16: sparse:     got unsigned long *
   arch/nios2/kernel/signal.c:78:16: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_ptr @@     got unsigned long * @@
   arch/nios2/kernel/signal.c:78:16: sparse:     expected unsigned long const [noderef] __user *__gu_ptr
   arch/nios2/kernel/signal.c:78:16: sparse:     got unsigned long *

vim +109 arch/nios2/kernel/signal.c

b53e906d255d7b Ley Foon Tan      2014-11-06  100  
b53e906d255d7b Ley Foon Tan      2014-11-06  101  asmlinkage int do_rt_sigreturn(struct switch_stack *sw)
b53e906d255d7b Ley Foon Tan      2014-11-06  102  {
b53e906d255d7b Ley Foon Tan      2014-11-06  103  	struct pt_regs *regs = (struct pt_regs *)(sw + 1);
b53e906d255d7b Ley Foon Tan      2014-11-06  104  	/* Verify, can we follow the stack back */
b53e906d255d7b Ley Foon Tan      2014-11-06  105  	struct rt_sigframe *frame = (struct rt_sigframe *) regs->sp;
b53e906d255d7b Ley Foon Tan      2014-11-06  106  	sigset_t set;
b53e906d255d7b Ley Foon Tan      2014-11-06  107  	int rval;
b53e906d255d7b Ley Foon Tan      2014-11-06  108  
96d4f267e40f95 Linus Torvalds    2019-01-03 @109  	if (!access_ok(frame, sizeof(*frame)))
b53e906d255d7b Ley Foon Tan      2014-11-06  110  		goto badframe;
b53e906d255d7b Ley Foon Tan      2014-11-06  111  
b53e906d255d7b Ley Foon Tan      2014-11-06  112  	if (__copy_from_user(&set, &frame->uc.uc_sigmask, sizeof(set)))
b53e906d255d7b Ley Foon Tan      2014-11-06  113  		goto badframe;
b53e906d255d7b Ley Foon Tan      2014-11-06  114  
b53e906d255d7b Ley Foon Tan      2014-11-06  115  	set_current_blocked(&set);
b53e906d255d7b Ley Foon Tan      2014-11-06  116  
b53e906d255d7b Ley Foon Tan      2014-11-06  117  	if (rt_restore_ucontext(regs, sw, &frame->uc, &rval))
b53e906d255d7b Ley Foon Tan      2014-11-06  118  		goto badframe;
b53e906d255d7b Ley Foon Tan      2014-11-06  119  
b53e906d255d7b Ley Foon Tan      2014-11-06  120  	return rval;
b53e906d255d7b Ley Foon Tan      2014-11-06  121  
b53e906d255d7b Ley Foon Tan      2014-11-06  122  badframe:
3cf5d076fb4d48 Eric W. Biederman 2019-05-23  123  	force_sig(SIGSEGV);
b53e906d255d7b Ley Foon Tan      2014-11-06  124  	return 0;
b53e906d255d7b Ley Foon Tan      2014-11-06  125  }
b53e906d255d7b Ley Foon Tan      2014-11-06  126  

:::::: The code at line 109 was first introduced by commit
:::::: 96d4f267e40f9509e8a66e2b39e8b95655617693 Remove 'type' argument from access_ok() function

:::::: TO: Linus Torvalds <torvalds@...ux-foundation.org>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ