linux-kernel - Re: [PATCH v2 01/12] iio: buffer-dma: Get rid of outgoing queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <EMC97R.6CF1131XF9J13@crapouillou.net>
Date:   Sun, 13 Feb 2022 19:25:26 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Michael Hennerich <Michael.Hennerich@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Christian König <christian.koenig@....com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v2 01/12] iio: buffer-dma: Get rid of outgoing queue

Hi Jonathan,

Le dim., févr. 13 2022 at 18:57:40 +0000, Jonathan Cameron 
<jic23@...nel.org> a écrit :
> On Mon,  7 Feb 2022 12:59:22 +0000
> Paul Cercueil <paul@...pouillou.net> wrote:
> 
>>  The buffer-dma code was using two queues, incoming and outgoing, to
>>  manage the state of the blocks in use.
>> 
>>  While this totally works, it adds some complexity to the code,
>>  especially since the code only manages 2 blocks. It is much easier 
>> to
>>  just check each block's state manually, and keep a counter for the 
>> next
>>  block to dequeue.
>> 
>>  Since the new DMABUF based API wouldn't use the outgoing queue 
>> anyway,
>>  getting rid of it now makes the upcoming changes simpler.
>> 
>>  With this change, the IIO_BLOCK_STATE_DEQUEUED is now useless, and 
>> can
>>  be removed.
>> 
>>  v2: - Only remove the outgoing queue, and keep the incoming queue, 
>> as we
>>        want the buffer to start streaming data as soon as it is 
>> enabled.
>>      - Remove IIO_BLOCK_STATE_DEQUEUED, since it is now functionally 
>> the
>>        same as IIO_BLOCK_STATE_DONE.
>> 
>>  Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  ---
> 
> Trivial process thing but change log should be here, not above as we 
> don't
> want it to end up in the main git log.

I'm kinda used to do this now, it's the policy for sending patches to 
the DRM tree. I like it because "git notes" disappear after rebases and 
it's a pain. At least like this I don't lose the changelog.

But okay, I'll change it for v3, if there's a v3.

Cheers,
-Paul

>>   drivers/iio/buffer/industrialio-buffer-dma.c | 44 
>> ++++++++++----------
>>   include/linux/iio/buffer-dma.h               |  7 ++--
>>   2 files changed, 26 insertions(+), 25 deletions(-)
>>